AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge rust-bitcoin/rust-bitcoin#7071: hashes: Allow deprecated_in_future in cpufeatures modules

Public commit record

What the developer wrote

Authored by Andrew Poelstra

91/100 · Strong
Merge rust-bitcoin/rust-bitcoin#7071: hashes: Allow deprecated_in_future in cpufeatures modules

f47d41e4fd86b8ff4f64a7e29045b75fcb970b61 hashes: Allow deprecated_in_future in cpufeatures modules (PeterXMR)

Pull request description:

Closes #6930.

The `cpufeatures::new!` macro expands to a call to `u8::max_value()`, which trips the crate-wide `deprecated_in_future` warning in `hashes`. The four cpuid modules already carried `#[allow(deprecated)]`, but that is a separate lint and never covered this warning. This adds `deprecated_in_future` to those four attributes, as suggested in the issue.

Bumping `cpufeatures` was not an option since `Cargo-minimal.lock` pins 0.2.5 and both 0.2.5 and 0.2.17 call `u8::max_value()`.

The second half of the issue, the removed clippy lint `from_iter_instead_of_collect`, was already fixed by #6963.

This patch was written with the assistance of an LLM (Claude Fable 5.1) and reviewed by me.


ACKs for top commit:
apoelstra:
ACK f47d41e4fd86b8ff4f64a7e29045b75fcb970b61; successfully ran local tests
Abeeujah:
ACK f47d41e4fd86b8ff4f64a7e29045b75fcb970b61


Tree-SHA512: 1e6067f4b742465c45c62f98a58794ccc8301731f22d984bf35138e41c43604a481daf2931ac06bf42cc8a6e904e79dfbd6eec3e26a0b5f79d4890d1d9374d8b
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a minor code-quality patch that adds a compiler warning suppression. It does not change any runtime behavior, cryptographic logic, or security boundary. The change simply tells Rust not to warn about a deprecated function used internally by a dependency (cpufeatures).

Recommended action

No security action required. Treat as routine maintenance.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.