What the developer wrote
Authored by Tobin C. Harding
units: Make fee module private
The `fee` module does not contain any types or functions, only a
single macro call for a bunch of math ops impls.
What changed, and why it matters
This commit makes a small internal Rust module named `fee` private instead of public. The module contained no usable types or functions—only a macro call generating internal math operations. This is a routine API cleanup that removes an accidentally exposed, empty-looking module from the public interface. There is no security bug being fixed here.
No security action required. Treat as a normal API-visibility cleanup. Downstream users relying on `bitcoin_units::fee` as a public module may need to update their code, but the module had no usable public items.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change converts pub mod fee; to mod fee; in units/src/lib.rs and updates three public-API snapshot files (api/units/*.txt) to remove pub mod bitcoin_units::fee. The commit message explicitly states the module contains no types or functions, only a macro call for math operator implementations. This is a backward-compatibility-affecting API change (semver breaking) but not a security patch.
Changed components
bitcoin_units public API surfaceunits/src/lib.rs module visibilityapi/units public-API snapshot filesInspect captured patch +1 / −4
diff --git a/api/units/all-features.txt b/api/units/all-features.txt
index 7ae200ee..07e3f8d6 100644
--- a/api/units/all-features.txt
+++ b/api/units/all-features.txt
@@ -2249,7 +2249,6 @@ pub mod bitcoin_units::amount::serde::as_sat::opt
pub mod bitcoin_units::amount::serde::as_str
pub mod bitcoin_units::amount::serde::as_str::opt
pub mod bitcoin_units::block
-pub mod bitcoin_units::fee
pub mod bitcoin_units::fee_rate
pub mod bitcoin_units::fee_rate::serde
pub mod bitcoin_units::fee_rate::serde::as_sat_per_kwu_floor
diff --git a/api/units/alloc-only.txt b/api/units/alloc-only.txt
index ededefef..c7bc8292 100644
--- a/api/units/alloc-only.txt
+++ b/api/units/alloc-only.txt
@@ -2086,7 +2086,6 @@ pub mod bitcoin_units::absolute
pub mod bitcoin_units::absolute::error
pub mod bitcoin_units::amount
pub mod bitcoin_units::block
-pub mod bitcoin_units::fee
pub mod bitcoin_units::fee_rate
pub mod bitcoin_units::locktime
pub mod bitcoin_units::locktime::absolute
diff --git a/api/units/no-features.txt b/api/units/no-features.txt
index 17de1146..9c35b0a5 100644
--- a/api/units/no-features.txt
+++ b/api/units/no-features.txt
@@ -2023,7 +2023,6 @@ pub mod bitcoin_units::absolute
pub mod bitcoin_units::absolute::error
pub mod bitcoin_units::amount
pub mod bitcoin_units::block
-pub mod bitcoin_units::fee
pub mod bitcoin_units::fee_rate
pub mod bitcoin_units::locktime
pub mod bitcoin_units::locktime::absolute
diff --git a/units/src/lib.rs b/units/src/lib.rs
index 587dba54..6c3f9426 100644
--- a/units/src/lib.rs
+++ b/units/src/lib.rs
@@ -34,6 +34,7 @@ extern crate alloc;
#[cfg(feature = "std")]
extern crate std;
+mod fee;
mod internal_macros;
#[doc(hidden)]
@@ -46,7 +47,6 @@ pub mod _export {
pub mod amount;
pub mod block;
-pub mod fee;
pub mod fee_rate;
pub mod locktime;
pub mod parse;
Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.