Public commit record
35/100 · Opaque
What the developer wrote
Authored by Nick Johnson
primitives: update API files
✓ Descriptive subject! No meaningful explanatory body
What changed, and why it matters
This commit only updates generated API snapshot text files to reflect recent changes in public function signatures. It does not change any source code, fix bugs, or alter program behavior. There is no security relevance.
Recommended action
No action required; this is a routine API-snapshot maintenance commit with no security implications.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates three primitives/api/*.txt files, which are rustdoc public-API snapshots used to track API stability. The signatures being recorded changed from accepting concrete slices (&[Transaction]) or Iterator bounds to accepting generic IntoIterator with Borrow<Transaction> constraints, and from Iterator to IntoIterator for calculate_root. These are API surface documentation updates only; no implementation code is modified.
Changed components
primitives/api/all-features.txtprimitives/api/alloc-only.txtprimitives/api/no-features.txtInspect captured patch +10 / −10
diff --git a/primitives/api/all-features.txt b/primitives/api/all-features.txt
index 11531010..be681f45 100644
--- a/primitives/api/all-features.txt
+++ b/primitives/api/all-features.txt
@@ -1342,8 +1342,8 @@ impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Checke
pub const bitcoin_primitives::block::Checked::IS_CHECKED: bool [impl: impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Checked]
impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Unchecked
pub const bitcoin_primitives::block::Unchecked::IS_CHECKED: bool [impl: impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Unchecked]
-pub fn bitcoin_primitives::block::compute_merkle_root(transactions: &[bitcoin_primitives::transaction::Transaction]) -> core::option::Option<bitcoin_primitives::merkle_tree::TxMerkleNode>
-pub fn bitcoin_primitives::block::compute_witness_root(transactions: &[bitcoin_primitives::transaction::Transaction]) -> core::option::Option<bitcoin_primitives::merkle_tree::WitnessMerkleNode>
+pub fn bitcoin_primitives::block::compute_merkle_root<T>(transactions: T) -> core::option::Option<bitcoin_primitives::merkle_tree::TxMerkleNode> where T: core::iter::traits::collect::IntoIterator, <T as core::iter::traits::collect::IntoIterator>::Item: core::borrow::Borrow<bitcoin_primitives::transaction::Transaction>
+pub fn bitcoin_primitives::block::compute_witness_root<T>(transactions: T) -> core::option::Option<bitcoin_primitives::merkle_tree::WitnessMerkleNode> where T: core::iter::traits::collect::IntoIterator, <T as core::iter::traits::collect::IntoIterator>::Item: core::borrow::Borrow<bitcoin_primitives::transaction::Transaction>
pub mod bitcoin_primitives::merkle_tree
pub mod bitcoin_primitives::merkle_tree::error
pub struct bitcoin_primitives::merkle_tree::error::TxMerkleNodeDecoderError(_)
@@ -1398,7 +1398,7 @@ pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::as_byte_array(&self)
pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::from_byte_array(bytes: [u8; 32]) -> Self
pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::to_byte_array(self) -> [u8; 32]
impl bitcoin_primitives::merkle_tree::TxMerkleNode
-pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::calculate_root<I: core::iter::traits::iterator::Iterator<Item = bitcoin_primitives::Txid>>(iter: I) -> core::option::Option<Self>
+pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::calculate_root<I: core::iter::traits::collect::IntoIterator<Item = bitcoin_primitives::Txid>>(iter: I) -> core::option::Option<Self>
pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::combine(&self, other: &Self) -> Self
pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::from_leaf(leaf: bitcoin_primitives::Txid) -> Self
impl bitcoin_consensus_encoding::decode::Decode for bitcoin_primitives::merkle_tree::TxMerkleNode
@@ -1611,7 +1611,7 @@ pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::as_byte_array(&
pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::from_byte_array(bytes: [u8; 32]) -> Self
pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::to_byte_array(self) -> [u8; 32]
impl bitcoin_primitives::merkle_tree::WitnessMerkleNode
-pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::calculate_root<I: core::iter::traits::iterator::Iterator<Item = bitcoin_primitives::Wtxid>>(iter: I) -> core::option::Option<Self>
+pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::calculate_root<I: core::iter::traits::collect::IntoIterator<Item = bitcoin_primitives::Wtxid>>(iter: I) -> core::option::Option<Self>
pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::combine(&self, other: &Self) -> Self
pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::from_leaf(leaf: bitcoin_primitives::Wtxid) -> Self
impl bitcoin_consensus_encoding::decode::Decode for bitcoin_primitives::merkle_tree::WitnessMerkleNode
diff --git a/primitives/api/alloc-only.txt b/primitives/api/alloc-only.txt
index 249a5d8b..e4b4269e 100644
--- a/primitives/api/alloc-only.txt
+++ b/primitives/api/alloc-only.txt
@@ -1250,8 +1250,8 @@ impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Checke
pub const bitcoin_primitives::block::Checked::IS_CHECKED: bool [impl: impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Checked]
impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Unchecked
pub const bitcoin_primitives::block::Unchecked::IS_CHECKED: bool [impl: impl bitcoin_primitives::block::Validation for bitcoin_primitives::block::Unchecked]
-pub fn bitcoin_primitives::block::compute_merkle_root(transactions: &[bitcoin_primitives::transaction::Transaction]) -> core::option::Option<bitcoin_primitives::merkle_tree::TxMerkleNode>
-pub fn bitcoin_primitives::block::compute_witness_root(transactions: &[bitcoin_primitives::transaction::Transaction]) -> core::option::Option<bitcoin_primitives::merkle_tree::WitnessMerkleNode>
+pub fn bitcoin_primitives::block::compute_merkle_root<T>(transactions: T) -> core::option::Option<bitcoin_primitives::merkle_tree::TxMerkleNode> where T: core::iter::traits::collect::IntoIterator, <T as core::iter::traits::collect::IntoIterator>::Item: core::borrow::Borrow<bitcoin_primitives::transaction::Transaction>
+pub fn bitcoin_primitives::block::compute_witness_root<T>(transactions: T) -> core::option::Option<bitcoin_primitives::merkle_tree::WitnessMerkleNode> where T: core::iter::traits::collect::IntoIterator, <T as core::iter::traits::collect::IntoIterator>::Item: core::borrow::Borrow<bitcoin_primitives::transaction::Transaction>
pub mod bitcoin_primitives::merkle_tree
pub mod bitcoin_primitives::merkle_tree::error
pub struct bitcoin_primitives::merkle_tree::error::TxMerkleNodeDecoderError(_)
@@ -1304,7 +1304,7 @@ pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::as_byte_array(&self)
pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::from_byte_array(bytes: [u8; 32]) -> Self
pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::to_byte_array(self) -> [u8; 32]
impl bitcoin_primitives::merkle_tree::TxMerkleNode
-pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::calculate_root<I: core::iter::traits::iterator::Iterator<Item = bitcoin_primitives::Txid>>(iter: I) -> core::option::Option<Self>
+pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::calculate_root<I: core::iter::traits::collect::IntoIterator<Item = bitcoin_primitives::Txid>>(iter: I) -> core::option::Option<Self>
pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::combine(&self, other: &Self) -> Self
pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::from_leaf(leaf: bitcoin_primitives::Txid) -> Self
impl bitcoin_consensus_encoding::decode::Decode for bitcoin_primitives::merkle_tree::TxMerkleNode
@@ -1497,7 +1497,7 @@ pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::as_byte_array(&
pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::from_byte_array(bytes: [u8; 32]) -> Self
pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::to_byte_array(self) -> [u8; 32]
impl bitcoin_primitives::merkle_tree::WitnessMerkleNode
-pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::calculate_root<I: core::iter::traits::iterator::Iterator<Item = bitcoin_primitives::Wtxid>>(iter: I) -> core::option::Option<Self>
+pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::calculate_root<I: core::iter::traits::collect::IntoIterator<Item = bitcoin_primitives::Wtxid>>(iter: I) -> core::option::Option<Self>
pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::combine(&self, other: &Self) -> Self
pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::from_leaf(leaf: bitcoin_primitives::Wtxid) -> Self
impl bitcoin_consensus_encoding::decode::Decode for bitcoin_primitives::merkle_tree::WitnessMerkleNode
diff --git a/primitives/api/no-features.txt b/primitives/api/no-features.txt
index 8146595e..9af75617 100644
--- a/primitives/api/no-features.txt
+++ b/primitives/api/no-features.txt
@@ -789,7 +789,7 @@ pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::as_byte_array(&self)
pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::from_byte_array(bytes: [u8; 32]) -> Self
pub const fn bitcoin_primitives::merkle_tree::TxMerkleNode::to_byte_array(self) -> [u8; 32]
impl bitcoin_primitives::merkle_tree::TxMerkleNode
-pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::calculate_root<I: core::iter::traits::iterator::Iterator<Item = bitcoin_primitives::Txid>>(iter: I) -> core::option::Option<Self>
+pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::calculate_root<I: core::iter::traits::collect::IntoIterator<Item = bitcoin_primitives::Txid>>(iter: I) -> core::option::Option<Self>
pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::combine(&self, other: &Self) -> Self
pub fn bitcoin_primitives::merkle_tree::TxMerkleNode::from_leaf(leaf: bitcoin_primitives::Txid) -> Self
impl bitcoin_consensus_encoding::decode::Decode for bitcoin_primitives::merkle_tree::TxMerkleNode
@@ -964,7 +964,7 @@ pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::as_byte_array(&
pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::from_byte_array(bytes: [u8; 32]) -> Self
pub const fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::to_byte_array(self) -> [u8; 32]
impl bitcoin_primitives::merkle_tree::WitnessMerkleNode
-pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::calculate_root<I: core::iter::traits::iterator::Iterator<Item = bitcoin_primitives::Wtxid>>(iter: I) -> core::option::Option<Self>
+pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::calculate_root<I: core::iter::traits::collect::IntoIterator<Item = bitcoin_primitives::Wtxid>>(iter: I) -> core::option::Option<Self>
pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::combine(&self, other: &Self) -> Self
pub fn bitcoin_primitives::merkle_tree::WitnessMerkleNode::from_leaf(leaf: bitcoin_primitives::Wtxid) -> Self
impl bitcoin_consensus_encoding::decode::Decode for bitcoin_primitives::merkle_tree::WitnessMerkleNode
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.