AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge rust-bitcoin/rust-bitcoin#6547: ci: upgrade to rbmt 0.5.3 and delete api files

Public commit record

What the developer wrote

Authored by Andrew Poelstra

100/100 · Strong
Merge rust-bitcoin/rust-bitcoin#6547: ci: upgrade to rbmt 0.5.3 and delete api files

53ea3d6f15afab5d35091122cd46f1d364811b5e api: remove api snapshot files (satsfy (Renato Britto))
c5f77ae9c9e08e266ca8b7393f0c786b2372bae9 ci: upload api-diff artifact for the labeller (satsfy (Renato Britto))
5c865aa63b600a978a24a4eaa25fd5b11fbdeda8 ci: upgrade to cargo-rbmt 0.5.3 (satsfy (Renato Britto))

Pull request description:

Supersedes https://github.com/rust-bitcoin/rust-bitcoin/pull/6522
Supersedes https://github.com/rust-bitcoin/rust-bitcoin/pull/6580
Supersedes https://github.com/rust-bitcoin/rust-bitcoin/pull/6612

This PR upgrades the CI to cargo-rbmt 0.5.1 and replicates the 0.32.xxx CI, borrowing heavily from https://github.com/rust-bitcoin/rust-bitcoin/pull/6508.

- Remove API files. Depend on diff check CI job replicating 0.32.xxx.
- Adapt the docs to cargo-rbmt 0.5.1.
- `docsrs` was merged into `docs` (with `--no-docsrs` for plain rustdoc).
- Put the version in the manifest as the source of truth.
- Upgrading cross so that it uses a modern TOML parser.


ACKs for top commit:
apoelstra:
ACK 53ea3d6f15afab5d35091122cd46f1d364811b5e; successfully ran local tests


Tree-SHA512: 34dfce4fe39d1eed72a340b2658d1067d568c447d14eb6bd6408dcbb2ffbfaa77f06f85a4bc44fee3bf59089b914656188c4ff40c380b42c14f4343407732053
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit is a routine maintenance change to the project's continuous integration (CI) setup. It upgrades an internal tool called cargo-rbmt to version 0.5.3, removes pre-generated API snapshot files from the repository, and adjusts scripts so those snapshots are generated on demand during CI instead. There is no change to the actual Bitcoin library code that users rely on, and no security-relevant behavior is introduced or fixed.

Recommended action

No security action required. This is a CI/tooling refactor. Reviewers may optionally verify that the new Generate-API job correctly fails on unintended public API changes and that the cargo-rbmt 0.5.3 upgrade does not break existing workflows.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.