Extend update toolchains to LTS branches

Rust Bitcoin/rust-bitcoin

11f42a41 View source ↗

Public commit record

What the developer wrote

Authored by Nick Johnson

45/100 · Thin

Extend update toolchains to LTS branches

✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body

The short version

What changed, and why it matters

This commit changes two GitHub workflow files so that an automated bot updates the Rust compiler toolchain on both the master branch and a long-term support branch (0.32.x), instead of only on master. It is a routine CI/CD maintenance change with no security relevance.

Recommended action

No security action needed; this is a benign CI configuration change.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The diff extends matrix build strategies in cron-weekly-update-nightly.yml and cron-weekly-update-stable.yml to run against [master, 0.32.x]. It sets the checkout ref, PR base, PR title suffix, and branch name per matrix entry. No code, dependencies, secrets, or permissions are changed beyond adding the branch dimension.

Changed components

.github/workflows/cron-weekly-update-nightly.yml.github/workflows/cron-weekly-update-stable.yml

Inspect captured patch +16 / −4

diff --git a/.github/workflows/cron-weekly-update-nightly.yml b/.github/workflows/cron-weekly-update-nightly.yml
index a49f9d0a..8e0a5d9a 100644
--- a/.github/workflows/cron-weekly-update-nightly.yml
+++ b/.github/workflows/cron-weekly-update-nightly.yml
@@ -12,9 +12,14 @@ jobs:
       contents: write
       id-token: write
       pull-requests: write
+    strategy:
+      matrix:
+        # Update toolchain on master and LTS branches.
+        branch: [master, 0.32.x]
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
+          ref: ${{ matrix.branch }}
           persist-credentials: false
       - name: Install cargo-rbmt
         run: cargo install --git https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools.git --rev $(cat rbmt-version) cargo-rbmt
@@ -26,10 +31,11 @@ jobs:
         uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8
         with:
           token: ${{ secrets.APOELSTRA_CREATE_PR_TOKEN }}
+          base: ${{ matrix.branch }}
           author: Update Nightly Rustc Bot <bot@example.com>
           committer: Update Nightly Rustc Bot <bot@example.com>
-          title: Automated weekly update to rustc (to ${{ env.nightly_version }})
+          title: Automated weekly update to rustc (to ${{ env.nightly_version }}) on ${{ matrix.branch }}
           body: |
            Automated update to Cargo.toml workspace metadata by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
           commit-message: Automated update to rustc ${{ env.nightly_version }}
-          branch: create-pull-request/weekly-nightly-update
+          branch: create-pull-request/weekly-nightly-update-${{ matrix.branch }}
diff --git a/.github/workflows/cron-weekly-update-stable.yml b/.github/workflows/cron-weekly-update-stable.yml
index 43160481..e874e243 100644
--- a/.github/workflows/cron-weekly-update-stable.yml
+++ b/.github/workflows/cron-weekly-update-stable.yml
@@ -11,9 +11,14 @@ jobs:
     permissions:
       contents: write
       pull-requests: write
+    strategy:
+      matrix:
+        # Update toolchain on master and LTS branches.
+        branch: [master, 0.32.x]
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
+          ref: ${{ matrix.branch }}
           persist-credentials: false
       - name: Install cargo-rbmt
         run: cargo install --git https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools.git --rev $(cat rbmt-version) cargo-rbmt
@@ -25,10 +30,11 @@ jobs:
         uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8
         with:
           token: ${{ secrets.APOELSTRA_CREATE_PR_TOKEN }}
+          base: ${{ matrix.branch }}
           author: Update Stable Rustc Bot <bot@example.com>
           committer: Update Stable Rustc Bot <bot@example.com>
-          title: Automated weekly update to rustc stable (to ${{ env.stable_version }})
+          title: Automated weekly update to rustc stable (to ${{ env.stable_version }}) on ${{ matrix.branch }}
           body: |
            Automated update to Cargo.toml workspace metadata by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
           commit-message: Automated update to rustc stable-${{ env.stable_version }}
-          branch: create-pull-request/weekly-stable-update
+          branch: create-pull-request/weekly-stable-update-${{ matrix.branch }}

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

Merge rust-bitcoin/rust-bitcoin#6670: ci: fix labeller permissions

Merge rust-bitcoin/rust-bitcoin#6657: Release tracking PR: `base58ck 0.5.0`

Merge rust-bitcoin/rust-bitcoin#6440: base58: Introduce `decode_check_to_array` for alloc-less decoding