contrib: remove old test scripts stale references
What changed, and why it matters
This commit is a routine cleanup of leftover references to old test scripts in configuration files. It removes stale entries from a GitHub labeler config, .gitignore, and a label generator, deletes an unused helper script, and inlines its only useful content into another script. There is no security-relevant change.
No security action needed. Treat as normal repository maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes dead references to dep_test, run_task.sh, extra_tests.sh, and test_vars.sh from .github/labeler.yml, .gitignore, and contrib/gen_label_config.sh. It deletes contrib/test_vars.sh and inlines its CRATES variable definition directly into contrib/test-miri.sh. No code paths, dependencies, permissions, or cryptographic logic are modified.
Changed components
.github/labeler.yml.gitignorecontrib/gen_label_config.shcontrib/test-miri.shcontrib/test_vars.shInspect captured patch +2 / −21
diff --git a/.github/labeler.yml b/.github/labeler.yml
index 884b5961..07a8085b 100644
--- a/.github/labeler.yml
+++ b/.github/labeler.yml
@@ -5,11 +5,6 @@ test:
- changed-files:
- any-glob-to-any-file: fuzz/**
- any-glob-to-any-file: '*/tests/**'
- - any-glob-to-any-file: 'dep_test'
- - any-glob-to-any-file: 'contrib/run_task.sh'
- - any-glob-to-any-file: 'contrib/test_vars.sh'
- - any-glob-to-any-file: '*/contrib/extra_tests.sh'
- - any-glob-to-any-file: '*/contrib/test_vars.sh'
doc:
- changed-files:
- any-glob-to-any-file: '**/*.md'
diff --git a/.gitignore b/.gitignore
index cf2a7cdb..05378fdc 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,7 +13,6 @@ bitcoin/target
hashes/target
# Test artifacts
-bitcoin/dep_test
mutants.out*
fuzz/coverage
diff --git a/contrib/gen_label_config.sh b/contrib/gen_label_config.sh
index 85ad9a93..1527891f 100755
--- a/contrib/gen_label_config.sh
+++ b/contrib/gen_label_config.sh
@@ -18,7 +18,7 @@ then
exit 1
fi
-excluded_crates="fuzz|dep_test"
+excluded_crates="fuzz"
CRATES="$(cd "$SCAN_DIR" && cargo metadata --no-deps --format-version 1 | jq -j -r '.packages | map(.manifest_path | rtrimstr("/Cargo.toml") | ltrimstr("'"$PWD"'/")) | join(" ")')"
diff --git a/contrib/test-miri.sh b/contrib/test-miri.sh
index 5e979a6f..66b603d7 100755
--- a/contrib/test-miri.sh
+++ b/contrib/test-miri.sh
@@ -4,7 +4,7 @@ set -euox pipefail
cd "$(dirname "$0")/.."
-. contrib/test_vars.sh
+CRATES="$(cargo metadata --no-deps --format-version 1 | jq -j -r '.packages | map(.manifest_path | rtrimstr("/Cargo.toml") | ltrimstr("'"$PWD"'/")) | join(" ")')"
target_features="$(rustc --print target-features | awk '{ if ($1 == "") { exit 0 } if (NR != 1 && $1 != "crt-static" && $1 != "soft-float") { if (NR == 2) { printf "+%s", $1 } else { printf ",+%s", $1 } } }')"
diff --git a/contrib/test_vars.sh b/contrib/test_vars.sh
deleted file mode 100644
index 3943aac6..00000000
--- a/contrib/test_vars.sh
+++ /dev/null
@@ -1,13 +0,0 @@
-# No shebang, this file should not be executed.
-# shellcheck disable=SC2148
-#
-#
-# Used by labeler.yaml
-#
-# Not to be confused with the per crate `test_vars.sh` used by
-# `rust-bitcoin-maintainer-tools-run_task.sh`.
-# disable verify unused vars, despite the fact that they are used when sourced
-# shellcheck disable=SC2034
-
-CRATES="$(cargo metadata --no-deps --format-version 1 | jq -j -r '.packages | map(.manifest_path | rtrimstr("/Cargo.toml") | ltrimstr("'"$PWD"'/")) | join(" ")')"
-DEPS="recent minimal"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.