Changes required due to upstream monero changes (#290)
What the developer wrote
Authored by Lee *!* Clagett
Changes required due to upstream monero changes (#290)
What changed, and why it matters
This commit is a routine compatibility update to keep the Monero Light Wallet Server (LWS) project building against recent changes in the upstream Monero codebase. It replaces a custom macro-based type declaration (POD_CLASS) with plain C++ struct forward declarations and adds a few missing standard library header includes. There is no indication in the commit that any security vulnerability is being fixed.
No security action required. Treat as a normal build-compatibility update. Verify that the project still compiles against the intended upstream Monero revision and that downstream consumers update their dependencies consistently.
Security signals we found
No security-relevant behavioral changes in the diff
Changes are limited to forward-declaration style and missing header includes
No memory safety, cryptographic, input validation, or authorization changes observed
Evidence from the diff
The diff updates five source files to adapt to upstream Monero API changes. In daemon_zmq.h and transactions.h, the local forward declarations switch from using the monero common/pod-class.h macro (POD_CLASS) to plain struct forward declarations, and the corresponding #include of pod-class.h is removed. In daemon_pub.h, scanner/commands.h, and ownership_test.cpp, missing includes (
Changed components
src/rpc/daemon_pub.hsrc/rpc/daemon_zmq.hsrc/rpc/scanner/commands.hsrc/util/ownership_test.cppsrc/util/transactions.hInspect captured patch +6 / −5
### src/rpc/daemon_pub.h
@@ -29,6 +29,7 @@
#include <cstdint>
#include <string>
+#include <vector>
#include "common/expect.h" // monero/src
#include "crypto/hash.h" // monero/src
### src/rpc/daemon_zmq.h
@@ -30,12 +30,11 @@
#include <cstdint>
#include <vector>
-#include "common/pod-class.h" // monero/src
#include "wire/json/fwd.h"
namespace crypto
{
- POD_CLASS hash;
+ struct hash;
}
namespace cryptonote
### src/rpc/scanner/commands.h
@@ -28,6 +28,7 @@
#include <boost/endian/buffers.hpp>
#include <cstdint>
+#include <string>
#include <vector>
#include "crypto/hash.h" // monero/src
### src/util/ownership_test.cpp
@@ -27,6 +27,7 @@
#include "ownership_test.h"
+#include <boost/numeric/conversion/cast.hpp>
#include <boost/optional/optional.hpp>
#include <boost/range/combine.hpp>
### src/util/transactions.h
@@ -29,13 +29,12 @@
#include <cstdint>
#include <utility>
-#include "common/pod-class.h"
#include "ringct/rctTypes.h"
namespace crypto
{
- POD_CLASS hash8;
- POD_CLASS key_derivation;
+ struct hash8;
+ struct key_derivation;
}
namespace lwsWhy this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.