What the developer wrote
Authored by woodser
test: remove fixed segfault todos
What changed, and why it matters
This commit simply removes two comment lines in test code that said certain tests occasionally crashed on Apple Silicon Macs. No actual code behavior was changed, so it does not introduce or fix a security issue on its own. It only updates internal notes about previously observed test failures.
No security action needed for this commit. If the underlying segfaults were fixed by a prior change, consider verifying that the fix is present in the relevant native/JNI build path and that CI passes on macOS arm64.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes two TODO comments in src/test/java/TestMoneroWalletFull.java that noted intermittent segfaults on macOS arm64 for testMoveTo() and testChangePassword(). No executable code, JNI bindings, build configuration, or wallet logic was modified. The commit title states these segfaults are ‘fixed’ and the TODOs are being removed, but the patch itself does not contain the fix.
Changed components
src/test/java/TestMoneroWalletFull.javaInspect captured patch +0 / −2
diff --git a/src/test/java/TestMoneroWalletFull.java b/src/test/java/TestMoneroWalletFull.java
index be51dc3..0a65cec 100644
--- a/src/test/java/TestMoneroWalletFull.java
+++ b/src/test/java/TestMoneroWalletFull.java
@@ -1045,7 +1045,6 @@ public class TestMoneroWalletFull extends TestMoneroWalletCommon {
}
// Can be moved
- // TODO: This test occasionally segfaults on macos arm64 (reproducible by looping test), but works on intel. Related to JNI binaries built on arm64?
@Test
public void testMoveTo() {
assumeTrue(TEST_NON_RELAYS);
@@ -2157,7 +2156,6 @@ public class TestMoneroWalletFull extends TestMoneroWalletCommon {
super.testMultisigStress();
}
- // TODO: This test occasionally segfaults on macos arm64 (reproducible by looping test), but works on intel. Related to JNI binaries built on arm64?
@Override
@Test
public void testChangePassword() {
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.