What the developer wrote
Authored by woodser
fix tests to relay after creating tx
What changed, and why it matters
This is a small test-only change. The developer fixed three test methods so they correctly configure whether a transaction should be relayed immediately or created first and relayed separately. No production wallet code was changed, and there is no security issue here.
No security action needed. Treat as a normal test fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies only src/test/java/TestMoneroWalletCommon.java. It removes .setRelay(true) from testSendSplit and adds .setRelay(false) to testCreateThenRelay and testCreateThenRelaySplit. This aligns the test configuration with each test’s stated purpose (immediate relay vs. create-then-relay). The underlying wallet relay/create logic is untouched.
Changed components
src/test/java/TestMoneroWalletCommon.javaInspect captured patch +3 / −3
diff --git a/src/test/java/TestMoneroWalletCommon.java b/src/test/java/TestMoneroWalletCommon.java
index 1c518d1..30a8e80 100644
--- a/src/test/java/TestMoneroWalletCommon.java
+++ b/src/test/java/TestMoneroWalletCommon.java
@@ -3360,21 +3360,21 @@ public abstract class TestMoneroWalletCommon {
@Test
public void testSendSplit() {
assumeTrue(TEST_RELAYS);
- testSendToSingle(new MoneroTxConfig().setCanSplit(true).setRelay(true));
+ testSendToSingle(new MoneroTxConfig().setCanSplit(true));
}
// Can create then relay a transaction to send to a single address
@Test
public void testCreateThenRelay() {
assumeTrue(TEST_RELAYS);
- testSendToSingle(new MoneroTxConfig().setCanSplit(false));
+ testSendToSingle(new MoneroTxConfig().setCanSplit(false).setRelay(false));
}
// Can create then relay split transactions to send to a single address
@Test
public void testCreateThenRelaySplit() {
assumeTrue(TEST_RELAYS);
- testSendToSingle(new MoneroTxConfig().setCanSplit(true));
+ testSendToSingle(new MoneroTxConfig().setCanSplit(true).setRelay(false));
}
private void testSendToSingle(MoneroTxConfig config) {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.