remove loop from change password test (#138)
What the developer wrote
Authored by woodser
remove loop from change password test (#138)
What changed, and why it matters
This commit removes a loop in a test that repeatedly changed a wallet password. The change is purely a test-code simplification and does not alter any production wallet logic. It is not a security fix.
No security action needed. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies TestMoneroWalletFull.java so that testChangePassword() runs once instead of 15 times. A TODO comment about an occasional macOS ARM64 segfault is moved but retained. No production code, cryptographic operations, or wallet APIs are changed.
Changed components
src/test/java/TestMoneroWalletFull.javaInspect captured patch +2 / −4
diff --git a/src/test/java/TestMoneroWalletFull.java b/src/test/java/TestMoneroWalletFull.java
index 5741125..92638a7 100644
--- a/src/test/java/TestMoneroWalletFull.java
+++ b/src/test/java/TestMoneroWalletFull.java
@@ -2149,13 +2149,11 @@ public class TestMoneroWalletFull extends TestMoneroWalletCommon {
super.testMultisigStress();
}
+ // TODO: This test occasionally segfaults on macos arm64 (reproducible by looping test), but works on intel. Related to JNI binaries built on arm64?
@Override
@Test
- // TODO: This test occasionally segfaults on macos arm64 (reproducible by looping test), but works on intel. Related to JNI binaries built on arm64?
public void testChangePassword() {
- for (int i = 0; i < 15; i++) {
- super.testChangePassword();
- }
+ super.testChangePassword();
}
@Override
Why this scored 13/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.