build: update monero-cpp and test initialized state for described txs (#162)
What the developer wrote
Authored by woodser
build: update monero-cpp and test initialized state for described txs (#162)
What changed, and why it matters
This commit only adds two new test assertions checking that transaction confirmation fields are populated. It is a test-only change with no visible security fix or code behavior change.
No security action needed based on the supplied diff. If reviewing the monero-cpp submodule update, request the submodule diff to assess whether it contains security-relevant changes.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds assertNotNull() checks for parsedTx.isConfirmed() and parsedTx.getNumConfirmations() in TestMoneroWalletCommon.java. The submodule external/monero-cpp is updated but no diff for it is provided. There is no patch to production code, no bounds check, no cryptographic change, and no input validation visible in the supplied diff.
Changed components
src/test/java/TestMoneroWalletCommon.javaInspect captured patch +3 / −1
diff --git a/src/test/java/TestMoneroWalletCommon.java b/src/test/java/TestMoneroWalletCommon.java
index 1533adf..d8acf4b 100644
--- a/src/test/java/TestMoneroWalletCommon.java
+++ b/src/test/java/TestMoneroWalletCommon.java
@@ -6074,6 +6074,8 @@ public abstract class TestMoneroWalletCommon {
assertFalse(parsedTx.getExtraHex().isEmpty());
assertTrue(parsedTx.getPaymentId() == null || !parsedTx.getPaymentId().isEmpty());
assertTrue(parsedTx.isOutgoing());
+ assertNotNull(parsedTx.isConfirmed());
+ assertNotNull(parsedTx.getNumConfirmations());
assertNotNull(parsedTx.getOutgoingTransfer());
assertNotNull(parsedTx.getOutgoingTransfer().getDestinations());
assertFalse(parsedTx.getOutgoingTransfer().getDestinations().isEmpty());
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.