add todos for jni tests which occasionally segfault
What the developer wrote
Authored by woodser
add todos for jni tests which occasionally segfault
What changed, and why it matters
This commit only adds comments (TODOs) to two test methods and changes one test to repeat 15 times instead of once. It documents that two tests sometimes crash on Apple Silicon Macs but work on Intel, possibly due to JNI binaries. There is no code fix or security change.
No security action needed for this commit. Treat as a test/documentation note. If investigating, focus on JNI native library builds for macOS arm64 and the two test cases (move wallet and change password).
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies src/test/java/TestMoneroWalletFull.java. It adds TODO comments to testMoveTo() and testChangePassword() noting occasional segfaults on macOS arm64 (reproducible by looping the test) while working on Intel, with a hypothesis about JNI binaries built on arm64. It also wraps super.testChangePassword() in a loop of 15 iterations, likely to aid reproduction. No production code, wallet logic, or security controls are changed.
Changed components
src/test/java/TestMoneroWalletFull.javaInspect captured patch +5 / −1
diff --git a/src/test/java/TestMoneroWalletFull.java b/src/test/java/TestMoneroWalletFull.java
index dc96c9e..5741125 100644
--- a/src/test/java/TestMoneroWalletFull.java
+++ b/src/test/java/TestMoneroWalletFull.java
@@ -1037,6 +1037,7 @@ public class TestMoneroWalletFull extends TestMoneroWalletCommon {
}
// Can be moved
+ // TODO: This test occasionally segfaults on macos arm64 (reproducible by looping test), but works on intel. Related to JNI binaries built on arm64?
@Test
public void testMoveTo() {
assumeTrue(TEST_NON_RELAYS);
@@ -2150,8 +2151,11 @@ public class TestMoneroWalletFull extends TestMoneroWalletCommon {
@Override
@Test
+ // TODO: This test occasionally segfaults on macos arm64 (reproducible by looping test), but works on intel. Related to JNI binaries built on arm64?
public void testChangePassword() {
- super.testChangePassword();
+ for (int i = 0; i < 15; i++) {
+ super.testChangePassword();
+ }
}
@Override
Why this scored 10/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.