AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 60 Cryptographic libraries

Merge pull request #11675

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11675

e69fd7f wallet: reject unverifiable message signatures (Samy)

ACKs: jpk68, selsta
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update fixes a flaw in Monero's wallet message-signing feature. Previously, a wallet that only held a view key (a 'view-only' wallet) could be asked to sign a message as if it held the spend key, producing a signature that looked valid but was actually created with the wrong private key. The fix makes the wallet verify it actually possesses the requested signing key before creating any signature, and it also adds checks that the requested address truly belongs to the wallet. This prevents misleading or unverifiable signatures from being generated.

Recommended action

Apply the patch and run the included functional, API, and unit tests. Users and integrators relying on message signing should upgrade, especially those exposing wallet RPC or view-only wallets, to ensure only verifiable signatures are produced.

Security signals we found

01

Prevents generation of unverifiable message signatures from wallets lacking the requested private key

02

Adds cryptographic key-ownership check inside wallet2::sign before signing

03

Adds address-belongs-to-wallet validation in WalletImpl::signMessage

04

Adds exception handling in wallet RPC signing path

05

Includes regression tests for view-only, subaddress, and wrong-address signing scenarios

Risk score

Why this scored 60/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.