What the developer wrote
Authored by jpk68
device_ledger: fix some comments
What changed, and why it matters
This commit only fixes spelling and wording in code comments (for example, changing 'Minimal' to 'Minimum' and 'lock' to 'unlock' where the comment was describing the wrong function). No actual program logic, function behavior, or security mechanism was changed.
No security action needed; this is a documentation/comment cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is limited to five comment-only changes across device_ledger.cpp and device_ledger.hpp. No executable code, control flow, data handling, or cryptographic operations were modified. The changes correct descriptive inaccuracies in comments for try_lock(), unlock(), get_secret_keys(), a version macro header, and a view-key handling note.
Changed components
src/device/device_ledger.cppsrc/device/device_ledger.hppInspect captured patch +5 / −5
diff --git a/src/device/device_ledger.cpp b/src/device/device_ledger.cpp
index e0a45a6..f3b4dbf 100644
--- a/src/device/device_ledger.cpp
+++ b/src/device/device_ledger.cpp
@@ -332,7 +332,7 @@ namespace hw {
MDEBUG( "Device "<<this->name << " LOCKed");
}
- //lock the device for a long sequence
+ //try to lock the device for a long sequence
bool device_ledger::try_lock(void) {
MDEBUG( "Ask for LOCKING(try) for device "<<this->name << " in thread ");
bool r = device_locker.try_lock();
@@ -344,7 +344,7 @@ namespace hw {
return r;
}
- //lock the device for a long sequence
+ //unlock the device for a long sequence
void device_ledger::unlock(void) {
try {
MDEBUG( "Ask for UNLOCKING for device "<<this->name << " in thread ");
@@ -632,7 +632,7 @@ namespace hw {
bool device_ledger::get_secret_keys(crypto::secret_key &vkey , crypto::secret_key &skey) {
AUTO_LOCK_CMD();
- //secret key are represented as fake key on the wallet side
+ //secret keys are represented as fake keys on the wallet side
memset(vkey.data, 0x00, 32);
memset(skey.data, 0xFF, 32);
diff --git a/src/device/device_ledger.hpp b/src/device/device_ledger.hpp
index 1db6fbf..dbfadac 100644
--- a/src/device/device_ledger.hpp
+++ b/src/device/device_ledger.hpp
@@ -41,7 +41,7 @@ namespace hw {
namespace ledger {
- /* Minimal supported version */
+ /* Minimum supported version */
#define MINIMAL_APP_VERSION_MAJOR 1
#define MINIMAL_APP_VERSION_MINOR 8
#define MINIMAL_APP_VERSION_MICRO 0
@@ -177,7 +177,7 @@ namespace hw {
//hmac for some encrypted value
HMACmap hmac_map;
- // To speed up blockchain parsing the view key maybe handle here.
+ // To speed up blockchain parsing the view key may be handled here.
crypto::secret_key viewkey = crypto::null_skey;
bool has_view_key = false;
bool requested_view_key = false;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.