What the developer wrote
Authored by a9oss
functional_tests_rpc: fix string.join()
What changed, and why it matters
This is a tiny Python 2-to-3 compatibility fix in a test helper script. It changes an outdated way of joining a list of strings into a modern one. The script only prints a help message listing available tests, so the change has no security relevance and does not affect the Monero wallet, daemon, or any user funds.
No security action needed. Treat as a normal test-suite maintenance patch.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit replaces string.join(DEFAULT_TESTS, ', ') with ', '.join(DEFAULT_TESTS) in tests/functional_tests/functional_tests_rpc.py. In Python 3, string.join() no longer exists, so the old code would raise an AttributeError when the script’s help path is triggered. The fix is purely a Python 3 compatibility repair in a non-production test utility.
Changed components
tests/functional_tests/functional_tests_rpc.pyInspect captured patch +1 / −1
diff --git a/tests/functional_tests/functional_tests_rpc.py b/tests/functional_tests/functional_tests_rpc.py
index 91a7b88..8ed700f 100755
--- a/tests/functional_tests/functional_tests_rpc.py
+++ b/tests/functional_tests/functional_tests_rpc.py
@@ -27,7 +27,7 @@ try:
sys.argv[4]
except:
print(USAGE)
- print('Available tests: ' + string.join(DEFAULT_TESTS, ', '))
+ print('Available tests: ' + ', '.join(DEFAULT_TESTS))
print('Or run all with "all"')
sys.exit(0)
Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.