What the developer wrote
Authored by jpk68
src: remove unused headers
What changed, and why it matters
This commit simply removes header files that were included in source code but not actually needed. It is a routine cleanup with no functional change to the Monero software and no security relevance.
No security action needed. Treat as normal maintenance cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes unused #include directives from src/net/i2p_address.cpp and src/simplewallet/simplewallet.cpp. Removing unused headers does not alter compiled behavior, reduce attack surface in a meaningful way, or introduce vulnerabilities. It is a code hygiene/refactoring change.
Changed components
src/net/i2p_address.cppsrc/simplewallet/simplewallet.cppInspect captured patch +0 / −15
diff --git a/src/net/i2p_address.cpp b/src/net/i2p_address.cpp
index 5864320..a0e3eed 100644
--- a/src/net/i2p_address.cpp
+++ b/src/net/i2p_address.cpp
@@ -29,17 +29,13 @@
#include "i2p_address.h"
#include <algorithm>
-#include <boost/spirit/include/karma_generate.hpp>
-#include <boost/spirit/include/karma_uint.hpp>
#include <cassert>
#include <cstring>
-#include <limits>
#include "net/error.h"
#include "net/host.h"
#include "serialization/keyvalue_serialization.h"
#include "storages/portable_storage.h"
-#include "string_tools_lexical.h"
namespace net
{
diff --git a/src/simplewallet/simplewallet.cpp b/src/simplewallet/simplewallet.cpp
index 50c61d4..54f0ff5 100644
--- a/src/simplewallet/simplewallet.cpp
+++ b/src/simplewallet/simplewallet.cpp
@@ -39,12 +39,10 @@
#include <boost/bind.hpp>
#include <locale.h>
-#include <thread>
#include <iostream>
#include <sstream>
#include <fstream>
#include <string_view>
-#include <ctype.h>
#include <boost/lexical_cast.hpp>
#include <boost/program_options.hpp>
#include <boost/algorithm/string.hpp>
@@ -54,22 +52,14 @@
#include <boost/filesystem.hpp>
#include "include_base_utils.h"
#include "console_handler.h"
-#include "common/i18n.h"
#include "common/command_line.h"
#include "common/util.h"
-#include "common/dns_utils.h"
-#include "common/base58.h"
#include "common/scoped_message_writer.h"
-#include "cryptonote_protocol/cryptonote_protocol_handler.h"
#include "simplewallet.h"
#include "cryptonote_basic/cryptonote_format_utils.h"
#include "storages/http_abstract_invoke.h"
#include "rpc/core_rpc_server_commands_defs.h"
-#include "crypto/crypto.h" // for crypto::secret_key definition
#include "mnemonics/electrum-words.h"
-#include "rapidjson/document.h"
-#include "common/json_util.h"
-#include "ringct/rctSigs.h"
#include "multisig/multisig.h"
#include "wallet/wallet_args.h"
#include "wallet/fee_priority.h"
@@ -80,7 +70,6 @@
#ifdef WIN32
#include <boost/locale.hpp>
-#include <boost/filesystem.hpp>
#include <fcntl.h>
#endif
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.