simplewallet: hide reached confirmation threshold
What the developer wrote
Authored by Samy
simplewallet: hide reached confirmation threshold
What changed, and why it matters
This is a tiny user-interface wording change in Monero's command-line wallet. It changes when and how a 'suggested threshold' of confirmations is shown to the user when viewing a transfer. Previously, the threshold was shown whenever it was greater than zero. Now, it is only shown when the actual number of confirmations is still below that threshold. Once the threshold is reached, the extra text is hidden. This is a cosmetic change, not a security fix.
No security action required. Treat as a normal UI/UX commit.
Security signals we found
No security-relevant code change detected
Change is purely informational UI text in wallet output
No cryptographic, consensus, or access-control changes
Evidence from the diff
In simplewallet.cpp’s show_transfer(), the condition for printing the suggested confirmation threshold was changed from suggested_threshold > 0 to confirmations < suggested_threshold. The displayed string was also slightly reworded from ‘suggested threshold’ to ‘suggested for this amount’. The logic governing actual unlock behavior is unchanged; only the informational message displayed to the user is modified.
Changed components
src/simplewallet/simplewallet.cppshow_transfer() user-facing outputInspect captured patch +2 / −2
diff --git a/src/simplewallet/simplewallet.cpp b/src/simplewallet/simplewallet.cpp
index 99d7932..93427a7 100644
--- a/src/simplewallet/simplewallet.cpp
+++ b/src/simplewallet/simplewallet.cpp
@@ -10139,8 +10139,8 @@ bool simple_wallet::show_transfer(const std::vector<std::string> &args)
uint64_t suggested_threshold = last_block_reward ? (pd.m_amount + last_block_reward - 1) / last_block_reward : 0;
if (bh >= last_block_height)
success_msg_writer() << "Locked: " << (bh - last_block_height) << " blocks to unlock";
- else if (suggested_threshold > 0)
- success_msg_writer() << std::to_string(confirmations) << " confirmations (" << suggested_threshold << " suggested threshold)";
+ else if (confirmations < suggested_threshold)
+ success_msg_writer() << std::to_string(confirmations) << " confirmations (" << suggested_threshold << " suggested for this amount)";
else
success_msg_writer() << std::to_string(confirmations) << " confirmations";
}
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.