What the developer wrote
Authored by Navid Rahimi
makefile: fix parallel build
What changed, and why it matters
This commit changes the Monero build system (Makefile) to fix problems when running builds in parallel. It explicitly tells CMake to generate Unix Makefiles and uses the standard $(MAKE) command instead of cmake --build. There is no security relevance in the diff itself.
No security action needed; treat as a normal build-system maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies Makefile targets (cmake-debug, debug, cmake-release, release, release-static) to add -G “Unix Makefiles” to cmake invocations and replace cmake --build . with $(MAKE). This is a build-system reliability fix intended to make parallel builds work correctly. No source code, cryptographic logic, network handling, or privilege boundary is changed.
Changed components
Makefile build targets (debug, release, release-static)Inspect captured patch +5 / −5
diff --git a/Makefile b/Makefile
index 2c03ed9..f074b69 100644
--- a/Makefile
+++ b/Makefile
@@ -52,10 +52,10 @@ depends:
cmake-debug:
mkdir -p $(builddir)/debug
- cd $(builddir)/debug && cmake -D CMAKE_BUILD_TYPE=Debug $(topdir)
+ cd $(builddir)/debug && cmake -G "Unix Makefiles" -D CMAKE_BUILD_TYPE=Debug $(topdir)
debug: cmake-debug
- cd $(builddir)/debug && cmake --build .
+ cd $(builddir)/debug && $(MAKE)
# Temporarily disable some tests:
# * libwallet_api_tests fail (Issue #895)
@@ -77,10 +77,10 @@ debug-all:
cmake-release:
mkdir -p $(builddir)/release
- cd $(builddir)/release && cmake -D CMAKE_BUILD_TYPE=Release $(topdir)
+ cd $(builddir)/release && cmake -G "Unix Makefiles" -D CMAKE_BUILD_TYPE=Release $(topdir)
release: cmake-release
- cd $(builddir)/release && cmake --build .
+ cd $(builddir)/release && $(MAKE)
release-test:
mkdir -p $(builddir)/release
@@ -92,7 +92,7 @@ release-all:
release-static:
mkdir -p $(builddir)/release
- cd $(builddir)/release && cmake -D STATIC=ON -D ARCH="default" -D CMAKE_BUILD_TYPE=Release $(topdir) && cmake --build .
+ cd $(builddir)/release && cmake -G "Unix Makefiles" -D STATIC=ON -D ARCH="default" -D CMAKE_BUILD_TYPE=Release $(topdir) && $(MAKE)
coverage:
mkdir -p $(builddir)/debug
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.