What the developer wrote
Authored by tobtoht
depends: drop unused patches
What changed, and why it matters
This commit simply deletes two old build-system patch files that are no longer used. The patches were designed to make builds more reproducible by removing timestamps and real git revision numbers from compiled tools. Removing the patches does not change any active code or build behavior, because the patches were already unused. There is no security issue here.
No action required. This is a cleanup commit with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes two unused depends patches: native_cctools/no-build-date.patch and native_libtapi/no_embed_git_rev.patch. The first patch removed a TIME/DATE print from the cctools linker to improve build reproducibility. The second patch replaced VCS-derived revision strings with a fixed placeholder in libtapi/LLVM CMake files, also for reproducibility. Since the patches are described as ‘unused’ and are being dropped, the commit has no functional effect on the current build. No vulnerability, bug fix, or security-relevant change is present in the diff.
Changed components
contrib/depends/patches/native_cctools/no-build-date.patchcontrib/depends/patches/native_libtapi/no_embed_git_rev.patchInspect captured patch +0 / −43
diff --git a/contrib/depends/patches/native_cctools/no-build-date.patch b/contrib/depends/patches/native_cctools/no-build-date.patch
deleted file mode 100644
index 8b7d1e1..0000000
--- a/contrib/depends/patches/native_cctools/no-build-date.patch
+++ /dev/null
@@ -1,12 +0,0 @@
-diff --git a/cctools/ld64/src/ld/Options.cpp b/cctools/ld64/src/ld/Options.cpp
-index 3bb8324..033760d 100644
---- a/cctools/ld64/src/ld/Options.cpp
-+++ b/cctools/ld64/src/ld/Options.cpp
-@@ -4279,7 +4279,6 @@ void Options::buildSearchPaths(int argc, const char* argv[])
- fVerbose = true;
- extern const char ldVersionString[];
- fprintf(stderr, "%s", ldVersionString);
-- fprintf(stderr, "BUILD " __TIME__ " " __DATE__"\n");
- fprintf(stderr, "configured to support archs: %s\n", ALL_SUPPORTED_ARCHS);
- // if only -v specified, exit cleanly
- if ( argc == 2 ) {
diff --git a/contrib/depends/patches/native_libtapi/no_embed_git_rev.patch b/contrib/depends/patches/native_libtapi/no_embed_git_rev.patch
deleted file mode 100644
index b898ccb..0000000
--- a/contrib/depends/patches/native_libtapi/no_embed_git_rev.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-diff --git a/src/llvm/CMakeLists.txt b/src/llvm/CMakeLists.txt
-index ab92717c8..4ad621ea3 100644
---- a/src/llvm/CMakeLists.txt
-+++ b/src/llvm/CMakeLists.txt
-@@ -752,9 +752,10 @@ set(LLVM_SRPM_USER_BINARY_SPECFILE ${CMAKE_CURRENT_SOURCE_DIR}/llvm.spec.in
- set(LLVM_SRPM_BINARY_SPECFILE ${CMAKE_CURRENT_BINARY_DIR}/llvm.spec)
- set(LLVM_SRPM_DIR "${CMAKE_CURRENT_BINARY_DIR}/srpm")
-
--# SVN_REVISION and GIT_COMMIT get set by the call to add_version_info_from_vcs.
--# DUMMY_VAR contains a version string which we don't care about.
--add_version_info_from_vcs(DUMMY_VAR)
-+# A call to add_version_info_from_vcs() was removed, leaving SVN_REVISION
-+# and GIT_COMMIT unset. Accordingly, LLVM_RPM_SPEC_REVISION is left empty.
-+# This variable appears to be unused. Since it may be used in a future
-+# update of native_libtapi this change serves as a precautionairy measure.
- if ( SVN_REVISION )
- set(LLVM_RPM_SPEC_REVISION "r${SVN_REVISION}")
- elseif ( GIT_COMMIT )
-diff --git a/src/llvm/cmake/modules/GenerateVersionFromCVS.cmake b/src/llvm/cmake/modules/GenerateVersionFromCVS.cmake
-index 6b1c71983..e16326ed6 100644
---- a/src/llvm/cmake/modules/GenerateVersionFromCVS.cmake
-+++ b/src/llvm/cmake/modules/GenerateVersionFromCVS.cmake
-@@ -24,7 +24,7 @@ include(VersionFromVCS)
- set(ENV{TERM} "dumb")
-
- function(append_info name path)
-- add_version_info_from_vcs(REVISION ${path})
-+ set(REVISION "git-0000000")
- string(STRIP "${REVISION}" REVISION)
- file(APPEND "${HEADER_FILE}.txt"
- "#define ${name} \"${REVISION}\"\n")
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.