AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 33 Cryptographic libraries

Merge pull request #11425

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11425

ba21737 FCMP++: tree building DB integration (j-berman)

ACKs: selsta, jpk68, thomasbuilds
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a large feature merge for Monero that adds database support for FCMP++ (Full Chain Membership Proof++) curve trees. It changes how outputs are indexed, adds new database tables, and includes a migration from database version 5 to 7. The changes are primarily structural and preparatory for a future privacy upgrade, not a finished activated protocol change. The code is gated behind a compile-time flag ENABLE_FCMP_INTEGRATION that is off by default.

Recommended action

Treat this as a significant but gated infrastructure change. Reviewers should focus on: (1) correctness of the DB migration and rollback behavior, (2) endianness handling in locked_outputs/timelocked_outputs DUPSORT keys, (3) whether the new txout_to_carrot_v1 variant tag reuse (0x1) for previously txout_to_scripthash could cause deserialization issues with old data, (4) validation that tree growth/trim invariants hold during reorgs, and (5) that ENABLE_FCMP_INTEGRATION remains off in release builds until the full protocol is ready. No immediate emergency patch is indicated.

Security signals we found

01

Large database schema change with new tables and DB version bump (5 -> 7)

02

Compile-time feature flag ENABLE_FCMP_INTEGRATION keeps new code disabled by default

03

New migration path migrate_5_7 with resumable batching and temporary cache table

04

Replacement of txout_to_scripthash with txout_to_carrot_v1 changes output variant serialization tags

05

Addition of custom unlock-time handling with deprecation block and mainnet-specific constants

06

New curve tree grow/trim logic with CHECK_AND_ASSERT_THROW_MES validation checks

07

Locked outputs table uses little-endian uint64 comparison due to binary serializer byte order

Risk score

Why this scored 33/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 6/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.