What the developer wrote
Authored by tobtoht
cmake: remove iwyu target
What changed, and why it matters
This commit simply removes an optional developer-only CMake target called 'iwyu' (include-what-you-use). It was a helper for cleaning up C++ #include statements and was never part of the compiled Monero software that users run. There is no security issue here.
No action required. This is a benign cleanup of a developer tooling target.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a CMake custom target that invoked iwyu_tool.py to run the include-what-you-use static analysis tool over the build. This target was conditional on Python and iwyu_tool.py being present, ran only when explicitly requested by a developer, and produced no build artifacts consumed by the project. It does not alter compiled code, dependencies, or runtime behavior.
Changed components
CMakeLists.txt (removed optional iwyu custom target)Inspect captured patch +0 / −10
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 69e39be..4841828 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1190,13 +1190,3 @@ endif()
# when ON - will install libwallet_merged into "lib"
option(BUILD_GUI_DEPS "Build GUI dependencies." OFF)
-
-find_package(PythonInterp)
-find_program(iwyu_tool_path NAMES iwyu_tool.py iwyu_tool)
-if (iwyu_tool_path AND PYTHONINTERP_FOUND)
- add_custom_target(iwyu
- COMMAND "${PYTHON_EXECUTABLE}" "${iwyu_tool_path}" -p "${CMAKE_BINARY_DIR}" -- --no_fwd_decls
- COMMENT "Running include-what-you-use tool"
- VERBATIM
- )
-endif()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.