What changed, and why it matters
This commit only removes stale 'TODO' comments from four source files. No code behavior is changed, no bugs are fixed, and no security issue is introduced or addressed.
No action required. This is a non-functional cleanup change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The merge commit deletes six comment lines containing ‘TODO’ markers in networking, DNS utility, and cryptonote account code. The actual executable logic, includes, and function bodies remain identical. There are no functional changes to review from a security standpoint.
Changed components
contrib/epee/include/net/abstract_tcp_server2.inlcontrib/epee/include/net/levin_protocol_handler_async.hsrc/common/dns_utils.cppsrc/cryptonote_basic/account.cppInspect captured patch +2 / −6
### contrib/epee/include/net/abstract_tcp_server2.inl
@@ -43,8 +43,8 @@
#include <boost/utility/value_init.hpp>
#include <boost/asio/bind_executor.hpp>
#include <boost/asio/steady_timer.hpp>
-#include <boost/date_time/posix_time/posix_time.hpp> // TODO
-#include <boost/thread/condition_variable.hpp> // TODO
+#include <boost/date_time/posix_time/posix_time.hpp>
+#include <boost/thread/condition_variable.hpp>
#include <boost/make_shared.hpp>
#include <boost/thread.hpp>
#include "string_tools_lexical.h"
### contrib/epee/include/net/levin_protocol_handler_async.h
@@ -735,7 +735,6 @@ void async_protocol_handler_config<t_connection_context>::delete_connections(siz
}
// close random connections from the provided set
- // TODO or better just keep removing random elements (performance)
unsigned seed = std::chrono::system_clock::now().time_since_epoch().count();
shuffle(connections.begin(), connections.end(), std::default_random_engine(seed));
for (size_t i = 0; i < connections.size() && i < count; ++i)
### src/common/dns_utils.cpp
@@ -361,7 +361,6 @@ namespace dns_utils
{
//-----------------------------------------------------------------------
-// TODO: parse the string in a less stupid way, probably with regex
std::string address_from_txt_record(const std::string& s)
{
// make sure the txt record has "oa1:xmr" and find it
### src/cryptonote_basic/account.cpp
@@ -296,13 +296,11 @@ DISABLE_VS_WARNINGS(4244 4345)
//-----------------------------------------------------------------
std::string account_base::get_public_address_str(network_type nettype) const
{
- //TODO: change this code into base 58
return get_account_address_as_str(nettype, false, m_keys.m_account_address);
}
//-----------------------------------------------------------------
std::string account_base::get_public_integrated_address_str(const crypto::hash8 &payment_id, network_type nettype) const
{
- //TODO: change this code into base 58
return get_account_integrated_address_as_str(nettype, m_keys.m_account_address, payment_id);
}
//-----------------------------------------------------------------Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.