AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 47 Cryptographic libraries

Merge pull request #11318

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11318

c1de072 cryptonote_core: handle future txpool times (Samy)

ACKs: jpk68, selsta
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This Monero update fixes a bug in how the transaction pool (mempool) handles transactions whose recorded arrival time is in the future. Before the fix, a transaction with a future receive_time could be treated as extremely old and wrongly removed from the pool, or cause misleading statistics. The patch clamps such times to the current time so they are not penalized. A new test confirms future-timestamped transactions stay in the pool while genuinely expired ones are still cleaned up.

Recommended action

Treat as a routine correctness/stability fix. Reviewers should verify that all call sites computing transaction age from receive_time use the same clamping, and consider whether receive_time should be validated on insertion to prevent future timestamps from being stored at all.

Security signals we found

01

Integer underflow/negative age avoided in mempool pruning logic

02

Future receive_time no longer causes premature eviction

03

Pool statistics clamped to current time to prevent inconsistent histograms

04

Regression test added for future receive_time behavior

Risk score

Why this scored 47/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 7/15
Affected reach 9/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.