What the developer wrote
Authored by tobtoht
epee: remove save_limit_to_file
What changed, and why it matters
This commit removes a function called save_limit_to_file and the calls to it. The function body was already empty (it did nothing), so this is a dead-code cleanup with no functional change to the program. There is no security issue visible in the diff.
No security action needed; this is a benign code-cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the static method declaration save_limit_to_file(int limit) from connection_basic.hpp and removes its empty definition from connection_basic.cpp. It also removes two calls to save_limit_to_file() inside set_rate_up_limit() and set_rate_down_limit(). Since the function had an empty body, removing it is behaviorally equivalent to the previous code. No security-sensitive logic is altered.
Changed components
contrib/epee/include/net/connection_basic.hppcontrib/epee/src/connection_basic.cppInspect captured patch +0 / −6
diff --git a/contrib/epee/include/net/connection_basic.hpp b/contrib/epee/include/net/connection_basic.hpp
index 93bfd75..7993060 100644
--- a/contrib/epee/include/net/connection_basic.hpp
+++ b/contrib/epee/include/net/connection_basic.hpp
@@ -184,7 +184,6 @@ class connection_basic { // not-templated base class for rapid developmet of som
// handlers and sleep
void sleep_before_packet(size_t packet_size, int phase, int q_len); // execute a sleep ; phase is not really used now(?)
- static void save_limit_to_file(int limit); ///< for dr-monero
static double get_sleep_time(size_t cb);
};
diff --git a/contrib/epee/src/connection_basic.cpp b/contrib/epee/src/connection_basic.cpp
index cd1e049..c1f9f8c 100644
--- a/contrib/epee/src/connection_basic.cpp
+++ b/contrib/epee/src/connection_basic.cpp
@@ -182,7 +182,6 @@ void connection_basic::set_rate_up_limit(uint64_t limit) {
CRITICAL_REGION_LOCAL( network_throttle_manager::m_lock_get_global_throttle_out );
network_throttle_manager::get_global_throttle_out().set_target_speed(limit);
}
- save_limit_to_file(limit);
}
void connection_basic::set_rate_down_limit(uint64_t limit) {
@@ -195,7 +194,6 @@ void connection_basic::set_rate_down_limit(uint64_t limit) {
CRITICAL_REGION_LOCAL( network_throttle_manager::m_lock_get_global_throttle_inreq );
network_throttle_manager::get_global_throttle_inreq().set_target_speed(limit);
}
- save_limit_to_file(limit);
}
uint64_t connection_basic::get_rate_up_limit() {
@@ -215,9 +213,6 @@ uint64_t connection_basic::get_rate_down_limit() {
}
return limit;
}
-
-void connection_basic::save_limit_to_file(int limit) {
-}
void connection_basic::set_tos_flag(int tos) {
connection_basic_pimpl::m_default_tos = tos;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.