AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 42 Cryptographic libraries

Merge pull request #11577

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11577

dfc2461 cryptonote_core: fix explicit tip templates (Samy)

ACKs: selsta, jpk68, jeffro256
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes how Monero's blockchain code builds empty 'block templates' when a miner or pool explicitly asks for a template based on the current chain tip. Before the fix, the code used a rough estimate of block weight instead of the accurate current median, which could produce templates that don't match the real main-chain rules. The mismatch could let a miner create a block that other nodes reject, or cause inconsistent rewards/fees between normal and explicit tip templates. A new test confirms that explicit-tip templates now behave identically to normal ones.

Recommended action

Treat as a low-to-moderate correctness fix worth including in release notes. Miners and pools using getblocktemplate with an explicit prev_block should upgrade. No immediate emergency response is indicated, but verify the new functional test passes and consider whether the old behavior could have caused any rejected blocks or fee/reward mismatches on the network.

Security signals we found

01

Consensus-relevant calculation changed (block weight median / cumulative weight limit)

02

Block template generation path corrected for explicit main-chain tip

03

New functional test asserts template parity between normal and explicit tip

04

Potential for mined block invalidity or reward/fees discrepancy if template diverges from consensus rules

Risk score

Why this scored 42/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.