AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 58 Cryptographic libraries

Merge pull request #11638

Public commit record

What the developer wrote

Authored by tobtoht

58/100 · Thin
Merge pull request #11638

4d2a0da tx_pool: fix missing double-spend flag (selsta)

ACKs: jpk68, jeffro256
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a bookkeeping bug in Monero's transaction memory pool. When a new transaction was added, the code sometimes failed to mark it as a 'double spend' even when another part of the system had already detected a conflict. The fix makes the pool record the double-spend warning from the validation step, not just from a later secondary check. A missing flag could let conflicting transactions sit in the pool longer than they should, potentially affecting which transactions miners see or how nodes relay them.

Recommended action

Apply the patch. After applying, verify that transactions flagged as double spends during validation are correctly marked in the pool and are not relayed or included in block templates. Consider adding regression tests that inject a tvc.m_double_spend=true transaction and assert meta.double_spend_seen is set.

Security signals we found

01

Missing/incorrect state flag for double-spend detection

02

Reliance on a single secondary check while ignoring primary validation signal

03

Transaction pool metadata inconsistency

04

Potential for conflicting transactions to be relayed or mined due to stale flag

Risk score

Why this scored 58/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.