What changed, and why it matters
This update blocks three wallet operations for Monero multisignature (multisig) wallets: ordinary cold signing of transactions, loading/parsing ordinary signed transactions, and importing output lists. Previously these operations may have been reachable for multisig wallets, which could bypass the special multisig signing workflow and potentially produce invalid or unsafe transactions. The fix adds explicit checks that throw errors or return false when a multisig wallet tries to use the non-multisig paths.
Treat as a security hardening fix. Users and integrators running multisig wallets should upgrade and verify that multisig transaction creation, signing, and submission use only the dedicated multisig APIs. Review whether any existing tooling relied on the now-blocked non-multisig paths for multisig wallets.
Security signals we found
Behavioral guard added to restrict operations for multisig wallets
Prevents use of single-sig cold signing in a multisig context
Prevents output import in a multisig context
Error messages explicitly describe multisig workflow enforcement
Evidence from the diff
The commit adds guard checks in src/wallet/wallet2.cpp: (1) sign_tx(unsigned_tx_set&, …) rejects multisig wallets before sanity-checking the unsigned tx set; (2) parse_tx_from_str rejects multisig wallets before parsing a signed tx string; (3) both overloads of import_outputs reject multisig wallets before proceeding. The intent is to enforce that multisig wallets use the dedicated multisig signing and transaction-submission flows rather than the single-sig cold-signing/output-import paths, which are not designed for multisig key schemes.
Changed components
src/wallet/wallet2.cppwallet2::sign_txwallet2::parse_tx_from_strwallet2::import_outputsInspect captured patch +15 / −0
### src/wallet/wallet2.cpp
@@ -8269,6 +8269,9 @@ bool wallet2::sign_tx(const std::string &unsigned_filename, const std::string &s
//----------------------------------------------------------------------------------------------------
bool wallet2::sign_tx(unsigned_tx_set &exported_txs, std::vector<wallet2::pending_tx> &txs, signed_tx_set &signed_txes)
{
+ THROW_WALLET_EXCEPTION_IF(m_multisig, error::wallet_internal_error,
+ "Multisig wallets must use multisig signing");
+
wallet::sanity_check_unsigned_tx_set(exported_txs.txes, m_account.get_keys(), m_subaddresses);
const auto &new_transfers = exported_txs.new_transfers;
@@ -8499,6 +8502,12 @@ bool wallet2::load_tx(const std::string &signed_filename, std::vector<tools::wal
//----------------------------------------------------------------------------------------------------
bool wallet2::parse_tx_from_str(const std::string &signed_tx_st, std::vector<tools::wallet2::pending_tx> &ptx, std::function<bool(const signed_tx_set &)> accept_func)
{
+ if (m_multisig)
+ {
+ LOG_PRINT_L0("Multisig wallets must use multisig transaction submission");
+ return false;
+ }
+
std::string s = signed_tx_st;
signed_tx_set signed_txs;
@@ -14751,6 +14760,9 @@ size_t wallet2::import_outputs(const std::tuple<uint64_t, uint64_t, std::vector<
{
PERF_TIMER(import_outputs);
+ THROW_WALLET_EXCEPTION_IF(m_multisig, error::wallet_internal_error,
+ "Multisig wallets cannot import outputs");
+
THROW_WALLET_EXCEPTION_IF(m_has_ever_refreshed_from_node, error::wallet_internal_error,
"Hot wallets cannot import outputs");
@@ -14837,6 +14849,9 @@ size_t wallet2::import_outputs(const std::tuple<uint64_t, uint64_t, std::vector<
{
PERF_TIMER(import_outputs);
+ THROW_WALLET_EXCEPTION_IF(m_multisig, error::wallet_internal_error,
+ "Multisig wallets cannot import outputs");
+
THROW_WALLET_EXCEPTION_IF(m_has_ever_refreshed_from_node, error::wallet_internal_error,
"Hot wallets cannot import outputs");
Why this scored 59/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.