What the developer wrote
Authored by yyforyongyu
sqldb/v2: align test helper build tags
Align the backend-swapped test helper files with the platforms
where their backing SQLite and Postgres helper implementations
actually exist.
This keeps the exported helper surface internally consistent even
on targets that current CI likely does not exercise. Before this
change, the SQLite helper file was still selected on no-SQLite
targets, and the Postgres helper file was still selected on
openbsd and netbsd under test_db_postgres even though the Docker
fixture was compiled out there.
What changed, and why it matters
This commit only adjusts which test helper files are compiled on which operating systems and CPU types. It does not change any production code, user-facing behavior, or security-sensitive logic. It is a build-tag cleanup for internal test helpers.
No security action required. Treat as a normal build/test maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates Go build constraints in sqldb/v2/test_postgres.go and sqldb/v2/test_sqlite.go so that test helpers are only built on platforms where their underlying SQLite/Postgres fixture implementations are actually compiled. This prevents compilation mismatches on platforms such as js, certain Windows/Linux architectures, and OpenBSD/NetBSD for Postgres. No runtime logic is modified.
Changed components
sqldb/v2/test_postgres.gosqldb/v2/test_sqlite.goInspect captured patch +2 / −2
diff --git a/sqldb/v2/test_postgres.go b/sqldb/v2/test_postgres.go
index 6557512..718002c 100644
--- a/sqldb/v2/test_postgres.go
+++ b/sqldb/v2/test_postgres.go
@@ -1,4 +1,4 @@
-//go:build test_db_postgres
+//go:build test_db_postgres && !js && !(windows && (arm || 386)) && !(linux && (ppc64 || mips || mipsle || mips64)) && !(netbsd || openbsd)
package sqldb
diff --git a/sqldb/v2/test_sqlite.go b/sqldb/v2/test_sqlite.go
index 6105080..1b49303 100644
--- a/sqldb/v2/test_sqlite.go
+++ b/sqldb/v2/test_sqlite.go
@@ -1,4 +1,4 @@
-//go:build !test_db_postgres
+//go:build !test_db_postgres && !js && !(windows && (arm || 386)) && !(linux && (ppc64 || mips || mipsle || mips64))
package sqldb
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.