AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Bitcoin

Merge pull request #10969 from darioAnongba/fix/chancloser-include-aux-outputs

Public commit record

What the developer wrote

Authored by Yong

73/100 · Adequate
Merge pull request #10969 from darioAnongba/fix/chancloser-include-aux-outputs

chancloser: account for aux close outputs in initial coop close fee baseline
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a bug in LND's cooperative channel-closing logic where extra 'auxiliary' outputs (used by custom/taproot channel types) were not counted when the initial closing fee was first estimated. If the fee was too low, the resulting close transaction could be rejected by the Bitcoin network's mempool. The fix adds a new 'shape' query so the closer knows the size of these extra outputs up front, includes them in the fee calculation, and then verifies that the final outputs match the declared shape before signing.

Recommended action

Review and merge if not already merged; ensure any custom channel implementations (e.g., taproot assets) correctly implement AuxCloseShape and return stable shapes independent of fee. Monitor for follow-up patches that extend RBF coop close paths to also use aux shapes.

Security signals we found

01

Underpriced transaction fee leading to mempool rejection / DoS of cooperative close

02

Fee estimation did not include auxiliary output weight

03

Added validation that concrete auxiliary outputs match declared shape before signing

04

Potential fee negotiation mismatch between parties if aux output shape changes

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.