AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 26 Bitcoin

bolt12: add NewInvoiceRequestFromOffer

Public commit record

What the developer wrote

Authored by bitromortac

50/100 · Thin
bolt12: add NewInvoiceRequestFromOffer

This ensures we copy all fields when replying to an offer.
✓ Descriptive subject✓ Provides an explanatory body
The short version

What changed, and why it matters

This commit adds a new helper function in LND's BOLT 12 implementation to build invoice requests from offers. It ensures all fields from an offer—including unknown future fields—are copied into the invoice request. The change is primarily a correctness/spec-compliance improvement and does not appear to fix an active security vulnerability. However, failing to copy all fields could previously have caused invoice requests to omit required offer data, potentially leading to payment failures or protocol non-compliance.

Recommended action

Review as a normal spec-compliance and robustness improvement. No urgent security action is indicated by the commit itself. If this commit is part of a larger release, consider whether related commits address any disclosed BOLT 12 security issue.

Security signals we found

01

New helper ensures BOLT 12 spec compliance: 'MUST copy all fields from the offer (including unknown fields)'

02

Unknown odd TLVs are carried forward via decodedTLVs sidecar, preventing silent omission of future offer fields

03

Validation added for required payer ID and metadata fields

04

No direct bug fix, CVE, or vulnerability disclosure referenced in commit or supplied materials

Risk score

Why this scored 26/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.