What the developer wrote
Authored by yyforyongyu
sqldb/v2: align test helper args
Use the same NewTestDBWithVersion argument order across the
SQLite and Postgres test helpers.
This was a latent build-tag API mismatch rather than a current
package-wide compile failure. Any shared helper that called
NewTestDBWithVersion(t, set, version) would compile under one
backend tag and fail under the other, but the mismatch stayed
hidden because nothing in sqldb/v2 called the helper yet.
What changed, and why it matters
This is a tiny code cleanup in a test-only helper. It swaps the order of two function arguments in the Postgres test helper so it matches the SQLite test helper. It does not change any production code, user-facing behavior, or runtime security. The commit itself notes it was a hidden build-tag mismatch that had not caused any actual compile failure yet.
No security action needed. Treat as normal code hygiene.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit changes the signature of NewTestDBWithVersion in sqldb/v2/test_postgres.go from (t, version, set) to (t, set, version) to align with the SQLite test helper. This is purely a test-infrastructure API consistency fix. There is no change to database logic, migrations, query handling, cryptography, networking, or any production path.
Changed components
sqldb/v2/test_postgres.goInspect captured patch +2 / −2
diff --git a/sqldb/v2/test_postgres.go b/sqldb/v2/test_postgres.go
index 718002c..fc62046 100644
--- a/sqldb/v2/test_postgres.go
+++ b/sqldb/v2/test_postgres.go
@@ -18,8 +18,8 @@ func NewTestDB(t *testing.T, sets []MigrationSet) *PostgresStore {
// NewTestDBWithVersion is a helper function that creates a Postgres database
// for testing and migrates it to the given version.
-func NewTestDBWithVersion(t *testing.T, version uint,
- set MigrationSet) *PostgresStore {
+func NewTestDBWithVersion(t *testing.T, set MigrationSet,
+ version uint) *PostgresStore {
pgFixture := NewTestPgFixture(t, DefaultPostgresFixtureLifetime)
t.Cleanup(func() {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.