paymentsdb: remove kvstore from sql db implementation
What the developer wrote
Authored by ziggie
paymentsdb: remove kvstore from sql db implementation
Now that every method of the interface was implemented we can
remove the embedded reference we put into place for the sql store
implementation so that the interface would succeed. This is now
removed.
What changed, and why it matters
This commit removes a leftover placeholder that made a new SQL-based payment database fall back to an older key-value store while its own methods were still being written. Now that all required methods are implemented, the fallback is no longer needed. There is no security issue here—this is a normal cleanup of completed refactoring work.
No action needed. This is a benign refactoring commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes the embedded KVStore field from the SQLStore struct in payments/db/sql_store.go. The embedded store was a temporary compatibility shim used while the SQLStore implementation was incomplete. With all interface methods now implemented directly on SQLStore, the shim is removed. This is a structural cleanup with no functional or security implications.
Changed components
payments/db/sql_store.goInspect captured patch +0 / −4
diff --git a/payments/db/sql_store.go b/payments/db/sql_store.go
index e7aab1c..0109ca1 100644
--- a/payments/db/sql_store.go
+++ b/payments/db/sql_store.go
@@ -97,10 +97,6 @@ type BatchedSQLQueries interface {
// SQLStore represents a storage backend.
type SQLStore struct {
- // TODO(ziggie): Remove the KVStore once all the interface functions are
- // implemented.
- KVStore
-
cfg *SQLStoreConfig
db BatchedSQLQueries
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.