AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

multi: move failed attempt cfg option to the router subsytem

Public commit record

What the developer wrote

Authored by ziggie

73/100 · Adequate
multi: move failed attempt cfg option to the router subsytem

Previously we had db and application logic mixed on the db level.
We now move the config option KeepFailedPaymentAttempts to the
ChannelRouter level and move it out of the db level.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit is a code cleanup: it moves a setting that controls whether failed Lightning payment attempts are kept in the database out of the database layer and into the routing subsystem. The user-visible behavior (keeping or deleting failed attempts based on configuration) is preserved. There is no security vulnerability introduced or fixed here.

Recommended action

No security action required. Treat as normal code-quality refactoring. Reviewers may optionally verify that `KeepFailedPaymentAttempts` is still correctly threaded from the top-level config through `server.go` to `routing.Config` and honored in `paymentLifecycle`.

Security signals we found

01

No security-relevant behavior change: the same configuration value still gates deletion of failed HTLC attempts

02

Refactoring only: moves conditional logic from database layer to application/router layer

03

No new input validation, cryptography, network parsing, or privilege changes

04

No mention of vulnerability, CVE, bug, or security fix in commit message or diff

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 5/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.