What the developer wrote
Authored by ziggie
makefile: add linter config check
What changed, and why it matters
This commit only changes the project's Makefile to add a new build step that verifies the linter configuration file is up to date. It does not modify any source code, network code, cryptography, or anything that could affect runtime security. There is no security issue here.
No security action needed. This is a routine developer-tooling/CI hygiene change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds a lint-config-check Make target that runs golangci-lint config verify and makes the existing lint target depend on it. It also adds a GOLINT_PKG variable pointing to the official golangci-lint package. No Go source files are changed, no dependencies are upgraded, and no security-sensitive logic is introduced.
Changed components
MakefileInspect captured patch +10 / −2
diff --git a/Makefile b/Makefile
index dcef899..f12cdb3 100644
--- a/Makefile
+++ b/Makefile
@@ -11,6 +11,7 @@ GOTOOL := GOWORK=off $(GOCC) tool -modfile=$(TOOLS_MOD)
BTCD_PKG := github.com/btcsuite/btcd
GOIMPORTS_PKG := github.com/rinchsan/gosimports/cmd/gosimports
+GOLINT_PKG := github.com/golangci/golangci-lint/v2/cmd/golangci-lint
GO_BIN := ${GOPATH}/bin
BTCD_BIN := $(GO_BIN)/btcd
@@ -339,12 +340,19 @@ check-go-version-dockerfile:
check-go-version: check-go-version-dockerfile check-go-version-yaml
#? lint-source: Run static code analysis
-lint-source: docker-tools
+lint-source: docker-tools
@$(call print, "Linting source.")
$(DOCKER_TOOLS) custom-gcl run -v $(LINT_WORKERS)
+#? lint-config-check: Verify that the lint config is up to date
+# We use the official linter here not our custom one because for checking the
+# config file it does not matter.
+lint-config-check:
+ @$(call print, "Checking lint config is up to date.")
+ $(GOTOOL) $(GOLINT_PKG) config verify -v
+
#? lint: Run static code analysis
-lint: check-go-version lint-source
+lint: check-go-version lint-config-check lint-source
#? protolint: Lint proto files using protolint
protolint:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.