What the developer wrote
Authored by Elle Mouton
funding: export MakeFundingScript
So that we can re-use this helper else where.
What changed, and why it matters
This commit simply renames an internal helper function from lowercase `makeFundingScript` to uppercase `MakeFundingScript` so it can be used by other parts of the codebase. It is a routine code-refactoring change with no visible security relevance.
No security action required. Treat as normal refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch exports makeFundingScript as MakeFundingScript in funding/manager.go and updates all internal call sites. The function logic is unchanged; only identifier visibility is modified. No behavioral or security-sensitive changes are present in the diff.
Changed components
funding/manager.goInspect captured patch +5 / −5
diff --git a/funding/manager.go b/funding/manager.go
index 5711ed8..ea33e8f 100644
--- a/funding/manager.go
+++ b/funding/manager.go
@@ -1365,7 +1365,7 @@ func (f *Manager) advancePendingChannelState(channel *channeldb.OpenChannel,
}
txid := &channel.FundingOutpoint.Hash
- fundingScript, err := makeFundingScript(channel)
+ fundingScript, err := MakeFundingScript(channel)
if err != nil {
log.Errorf("unable to create funding script for "+
"ChannelPoint(%v): %v",
@@ -3053,9 +3053,9 @@ func (f *Manager) waitForFundingWithTimeout(
}
}
-// makeFundingScript re-creates the funding script for the funding transaction
+// MakeFundingScript re-creates the funding script for the funding transaction
// of the target channel.
-func makeFundingScript(channel *channeldb.OpenChannel) ([]byte, error) {
+func MakeFundingScript(channel *channeldb.OpenChannel) ([]byte, error) {
localKey := channel.LocalChanCfg.MultiSigKey.PubKey
remoteKey := channel.RemoteChanCfg.MultiSigKey.PubKey
@@ -3102,7 +3102,7 @@ func (f *Manager) waitForFundingConfirmation(
// Register with the ChainNotifier for a notification once the funding
// transaction reaches `numConfs` confirmations.
txid := completeChan.FundingOutpoint.Hash
- fundingScript, err := makeFundingScript(completeChan)
+ fundingScript, err := MakeFundingScript(completeChan)
if err != nil {
log.Errorf("unable to create funding script for "+
"ChannelPoint(%v): %v", completeChan.FundingOutpoint,
@@ -3818,7 +3818,7 @@ func (f *Manager) annAfterSixConfs(completeChan *channeldb.OpenChannel,
shortChanID.ToUint64(), completeChan.FundingOutpoint,
numConfs)
- fundingScript, err := makeFundingScript(completeChan)
+ fundingScript, err := MakeFundingScript(completeChan)
if err != nil {
return fmt.Errorf("unable to create funding script "+
"for ChannelPoint(%v): %v",
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.