AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

multi: use feature bits to pick which taproot nonce field to use

Public commit record

What the developer wrote

Authored by Olaoluwa Osuntokun

73/100 · Adequate
multi: use feature bits to pick which taproot nonce field to use

Before this commit, we'd _always_ set both nonces fields, for both the
staging and the final taproot channels type.

With this commit, we've switched to only setting the new nonce map field
for the final taproot feature bit type.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit changes how Lightning taproot channels send cryptographic nonces during channel recovery and revocation. Previously, both an old single-nonce field and a new map-of-nonces field were always sent. Now, only one is sent depending on whether the channel is a 'staging' or 'final' taproot channel type. This is a protocol-correctness and compatibility change, not a clear security bug fix, though it reduces ambiguity in peer communication.

Recommended action

Review whether any peer still expects both fields or misinterprets the absence of the legacy field as missing data. Ensure customSigningRand cannot be set in production builds. Consider adding fuzz/negative tests for LocalVerNonce when neither field is populated or the map lacks the funding txid.

Security signals we found

01

MuSig2 nonce handling changed from dual-field to single-field based on feature bit

02

New deterministic nonce randomness option added with explicit private-key-extraction warning

03

Protocol field selection now depends on IsTaprootFinal channel type

04

Helper abstracts nonce extraction with map-first, legacy-second fallback

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.