What the developer wrote
Authored by ziggie
routerrpc: fix comment in lsp heuristic
What changed, and why it matters
This commit only changes two comments in the source code. It corrects a misleading description: the code actually selects the route with the highest fee, not the cheapest route. No program logic, behavior, or security boundary is changed.
No action required. This is a documentation-only comment fix with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates two comments in lnrpc/routerrpc/router_server.go to accurately reflect that LSP route probing returns the route with the highest fee rather than the cheapest route. There are no code changes, no functional modifications, and no security implications.
Changed components
lnrpc/routerrpc/router_server.goInspect captured patch +2 / −2
diff --git a/lnrpc/routerrpc/router_server.go b/lnrpc/routerrpc/router_server.go
index 27cd858..a4031b1 100644
--- a/lnrpc/routerrpc/router_server.go
+++ b/lnrpc/routerrpc/router_server.go
@@ -577,7 +577,7 @@ func (s *Server) probePaymentRequest(ctx context.Context, paymentRequest string,
// If the heuristic indicates an LSP, we filter and group route hints by
// public LSP nodes, then probe each unique LSP separately and return
- // the cheapest route.
+ // the route with the highest fee.
lspGroups, err := prepareLspRouteHints(
hints, *payReq.MilliSat, s.cfg.RouterBackend.HasNode,
)
@@ -802,7 +802,7 @@ func isLSP(routeHints [][]zpay32.HopHint, invoiceTarget []byte,
// LspRouteGroup represents a group of route hints that share the same public
// LSP destination node. This is needed when probing LSPs separately to find
-// the cheapest route.
+// the route with the highest fee.
type LspRouteGroup struct {
// LspHopHint is the hop hint for the LSP node with worst-case fees and
// CLTV delta.
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.