AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

fix: sso missing user id (#4082)

Public commit record

What the developer wrote

Authored by Vlad Stan

65/100 · Adequate
fix: sso missing user id (#4082)
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a bug in LNbits' single-sign-on (SSO) login code. The login endpoint required callers to supply a 'user_id' value, but in normal use it should be optional. Without the fix, users trying to log in via an external provider such as Keycloak would hit an error because the parameter was missing. The change makes the parameter optional by giving it a default value of None, and adds a test that confirms the redirect to the SSO provider still works when no user_id is supplied.

Recommended action

Treat as a normal bug-fix commit. Reviewers should confirm that downstream SSO callback/token handling safely handles user_id=None and that no other endpoints have similar unintended required parameters.

Security signals we found

01

Required parameter made optional to restore intended SSO login flow

02

New regression test added for missing user_id scenario

03

No authorization bypass or privilege escalation visible in diff

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 6/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.