AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 32 Bitcoin

Add lightning addresses for wallets in core (#4035)

Public commit record

What the developer wrote

Authored by blackcoffeexbt

73/100 · Adequate
Add lightning addresses for wallets in core (#4035)

Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds a new feature that lets every LNbits wallet have its own Lightning Address (like an email-style address for receiving Bitcoin payments). It includes database changes, new API endpoints, validation rules, and admin settings. The commit itself is a feature addition, not a stated security fix. There are no obvious critical vulnerabilities in the diff, but the new code introduces several areas where security assumptions matter, such as who can set an address, what characters are allowed, and how payments are created when someone pays the address.

Recommended action

Treat this as a routine feature commit, not an emergency patch. Reviewers and operators should verify that the new Lightning Address endpoints are properly integrated with existing rate-limiting, authentication/authorization, and invoice-creation safeguards; confirm that the large `MAX_SENDABLE_MSAT` and fee-charging paths behave as intended; and ensure the extension-redirect logic in `lnurl_api.py` does not create request-routing confusion or open SSRF/loop issues. No immediate patching is indicated solely from this diff.

Security signals we found

01

New public unauthenticated endpoint `/.well-known/lnurlp/{username}` resolves wallet IDs from a user-controlled string and triggers invoice creation

02

User-controlled `username`/`local_part` is validated by regex and blacklist before being stored or used for lookup

03

Callback endpoint `/api/v1/lnurl/wallet/{username}/cb` creates invoices for arbitrary amounts within a very large max range (2.1 billion sats)

04

Admin API `/user/{user_id}/wallet/{wallet}/lightning-address` allows setting an address for any wallet with `allow_blacklisted=True` and no fee charge

05

Wallet update API `/api/v1/wallet` allows setting a custom address only when `lnbits_allow_custom_wallet_lightning_addresses` is true and charges a fee if configured

06

Middleware change `is_duplicate_well_known()` avoids double-handling `/.well-known/lnurlp` between core and extensions

07

Database unique index on `lightning_address` prevents duplicate addresses

08

No explicit security disclosure, CVE, or vendor acknowledgment present in the commit or supplied references

Risk score

Why this scored 32/100

Our methodology →
Potential impact 5/30
Exploitability 5/25
Stealth signal 5/15
Affected reach 10/15
Confidence 5/10
Evidence quality 2/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.