AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 67 Bitcoin

fix: respect shared wallet permissions for payment updates (#4338)

Public commit record

What the developer wrote

Authored by Vlad Stan

70/100 · Adequate
fix: respect shared wallet permissions for payment updates (#4338)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a permission bug in LNbits where users of shared wallets could update or settle/cancel payments even when they only had view-only access. It also adds a check so that settle/cancel actions only work on special 'hold invoices,' preventing them from being misused on regular payments. The change is a security fix for access control.

Recommended action

Review shared-wallet permission model for other mutating endpoints; ensure can_update_payments() is consistently applied; deploy the patch promptly for instances using shared wallets.

Security signals we found

01

Access-control bypass fix for shared wallet payment updates

02

New permission check can_update_payments() tied to shared wallet receive/send permissions

03

New hold_invoice guard on settle/cancel endpoints

04

Regression tests added for unauthorized shared-wallet actions and non-hold-invoice actions

Risk score

Why this scored 67/100

Our methodology →
Potential impact 18/30
Exploitability 15/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.