AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 32 Bitcoin

fix: update API response structure and fix checking_id mismatch (#3478)

Public commit record

What the developer wrote

Authored by Sat

85/100 · Strong
fix: update API response structure and fix checking_id mismatch (#3478)

Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit updates LNbits' Strike wallet integration to match a newer Strike API response format and fixes a mismatch in how outgoing payments are tracked. Previously, the code used Strike's internal payment ID as the tracking key ('checking_id'), but now it uses the Lightning invoice's payment hash. The change also adds stricter error handling and fee parsing. The mismatch could have caused LNbits to lose track of whether a payment succeeded, failed, or is still pending, which in turn could lead to double-paying an invoice or incorrectly marking a payment as failed. There is no evidence in the commit of an active security exploit or a CVE.

Recommended action

Review the Strike wallet integration in production to ensure pending payments keyed by the old paymentId are migrated or handled, and verify that status polling now resolves correctly with payment_hash. Consider adding regression tests for the checking_id consistency across pay_invoice and get_payment_status. No emergency patch is indicated from the diff alone.

Security signals we found

01

checking_id mismatch fix between outgoing payment creation and status polling

02

payment tracking key changed from provider paymentId to invoice payment_hash

03

new BOLT11 invoice decoding and validation before payment attempt

04

improved error handling and logging for payment quote creation/execution

05

updated fee/preimage parsing for changed Strike API response shape

Risk score

Why this scored 32/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 6/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.