AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 36 Bitcoin

[feat] configure HTTPS Only settings (#3801)

Public commit record

What the developer wrote

Authored by Vlad Stan

53/100 · Thin
[feat] configure HTTPS Only settings (#3801)
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds a new configuration option that lets LNbits administrators decide whether authentication cookies must only be sent over HTTPS and whether single-sign-on (SSO) should reject plain HTTP connections. By default the setting is turned on, which improves security for production deployments. The change also fixes a related bug where SSO login responses did not include the user's account ID in the access token. Test and CI configurations explicitly disable the HTTPS-only requirement so automated tests can run without TLS.

Recommended action

No immediate action required; this is a hardening/feature commit. Operators should ensure `AUTH_HTTPS_ONLY` remains enabled in production and that LNbits is served behind TLS. Reviewers may want to verify that no other auth cookies are still missing the secure flag and that the SSO `allow_insecure_http` logic cannot be bypassed by reverse-proxy misconfiguration.

Security signals we found

01

Adds secure cookie flag controlled by HTTPS-only setting

02

Adds SameSite=Lax to auth cookies

03

SSO provider now respects HTTPS-only setting for insecure HTTP allowance

04

Fixes missing user ID in SSO redirect access token payload

05

Default is secure (True), with explicit opt-out for local/dev/test use

Risk score

Why this scored 36/100

Our methodology →
Potential impact 8/30
Exploitability 6/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.