AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 37 Bitcoin

feat: Adds paypal as a fiat choice (#3637)

Public commit record

What the developer wrote

Authored by Arc

80/100 · Strong
feat: Adds paypal as a fiat choice (#3637)

Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds PayPal as a new fiat payment option to LNbits, a Bitcoin Lightning wallet platform. It introduces code that lets users create PayPal orders and subscriptions, and receive webhook notifications when PayPal payments complete. The change is a feature addition, not a documented security fix. There are some code-quality concerns in how PayPal webhooks are verified and how subscription metadata is handled, but nothing in the commit or supplied references proves these are exploitable vulnerabilities.

Recommended action

Treat this as a normal feature commit, not a confirmed security patch. Operators enabling PayPal should configure paypal_webhook_id and ensure the callback URL is not publicly reachable except by PayPal. Reviewers should verify that missing webhook verification causes the callback to be rejected rather than accepted, and that subscription metadata deserialization is robust against unexpected or attacker-controlled custom_id values. Consider adding explicit tests for webhook verification failure paths.

Security signals we found

01

Webhook verification can be silently skipped when paypal_webhook_id or required PayPal headers are missing

02

Callback handler parses request body twice (request.body() then request.json()) which is fragile but not directly a vulnerability

03

Subscription metadata from PayPal custom_id/custom is JSON-deserialized and used to create invoices without visible integrity check beyond PayPal signature verification

04

New third-party API integration increases attack surface (OAuth token handling, HTTPS dependency, provider-specific webhook endpoint)

05

No explicit security relevance disclosed by vendor; no CVE or advisory supplied

Risk score

Why this scored 37/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 7/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.