AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 65 Bitcoin

Merge commit from fork

Public commit record

What the developer wrote

Authored by Riccardo Balbo

51/100 · Thin
Merge commit from fork

* fix: don't show unsafe html in lnurlp notifications

* fix: lnurlp success aes decryption

* regenerate bundle

---------

Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>
✓ Subject identifies a change✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes two security-related bugs in the LNbits wallet's handling of LNURL-pay payments. First, it stops payment success notifications from rendering raw HTML supplied by a third-party LNURL service, which could have allowed attackers to inject malicious web content (cross-site scripting). Second, it corrects how AES-encrypted success messages are decrypted so users can actually read the confirmation. The changes are in minified JavaScript bundles and one source file, but the full source diff is truncated, so we cannot verify every detail.

Recommended action

Deploy the patched bundles and source. Review the non-minified wallet.js to ensure all user-controlled fields from lnurlp success_action (url, message, aes ciphertext, description) are escaped or rendered as text, and that decryptLnurlPayAES returns sanitized output. Consider adding automated tests for malicious success_action payloads.

Security signals we found

01

Commit message explicitly states 'don't show unsafe html in lnurlp notifications'

02

Removal of html:true in Quasar.Notify.create for LNURL-pay success_action URL messages

03

Direct URL interpolation into notification HTML changed to plain text/link rendering

04

AES success_action branch references corrected from undefined variables to decrypted value/description

05

Changes are in wallet-facing payment flow (LNURL-pay), a common phishing/injection surface

Risk score

Why this scored 65/100

Our methodology →
Potential impact 20/30
Exploitability 15/25
Stealth signal 10/15
Affected reach 10/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.