AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 34 Bitcoin

fix(lnpay): return checking_id from create_invoice (#4295)

Public commit record

What the developer wrote

Authored by Amartya Vikram Singh

70/100 · Adequate
fix(lnpay): return checking_id from create_invoice (#4295)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a bug in the LNPay wallet integration where newly created Lightning invoices were not returning their internal tracking ID ('checking_id'). Without this ID, LNbits could not reliably match future payment updates to the correct invoice, which can lead to invoices being stuck as 'pending' indefinitely or being incorrectly tracked. The fix is a one-line addition that includes the invoice ID in the response, plus a new unit test to prevent regression.

Recommended action

Review other wallet backends in lnbits/wallets/ for similar omissions of checking_id in create_invoice responses, and ensure payment-status polling logic handles missing checking_id defensively.

Security signals we found

01

Missing correlation identifier in payment response

02

Potential invoice state desynchronization between LNbits and LNPay backend

03

Regression test added for payment identifier handling

Risk score

Why this scored 34/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 6/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.