What changed, and why it matters
This update turns off a default paid-extension review service in LNbits. It stops the wallet from automatically contacting a third-party payment/review server when it lists or updates extensions, and resets the default review URL to empty. It also renames the local auth key file so a fresh key is generated, which helps avoid reusing a potentially exposed key. The changes are defensive: they reduce the chance that a compromised or malicious review server could trick users into paying for extensions or leak information about installed extensions.
Deploy this patch promptly. After upgrading, verify that `lnbits_extensions_reviews_url` is empty unless you intentionally configure a trusted review server. Monitor for a new `.lnbits_auth_key_v1` file and rotate any services that depend on the old auth secret. Review extension auto-update behavior in logs to ensure paid extensions still work when explicitly requested.
Security signals we found
Default third-party review/payment URL removed
Migration forcibly resets stored review URL to empty
Background extension update/install no longer queries remote pay_link for pricing
Auth secret key file renamed, causing key rotation on next start
Auto-update preserves existing payment amount metadata
Evidence from the diff
The commit disables the built-in ‘paid reviews’ feature by default. Key changes: (1) lnbits_extensions_reviews_url default is changed from a hardcoded demo endpoint to an empty string; (2) a migration m058_clear_extensions_reviews_url resets any existing review URL in the database and in runtime settings; (3) get_extension_releases gains an include_payment_info flag so background tasks like auto-update and default-install no longer call check_payment_requirements() against the review/payment server; (4) auto-update logic now preserves cost_sats from existing payments; (5) the auth secret key file is renamed from .lnbits_auth_key to .lnbits_auth_key_v1, forcing a new key. Tests are added to verify that release prices are only fetched for interactive release lookups.
Changed components
lnbits/app.pylnbits/core/migrations.pylnbits/core/models/extensions.pylnbits/core/services/extensions.pylnbits/settings.pyInspect captured patch +208 / −13
### lnbits/app.py
@@ -370,7 +370,9 @@ async def build_all_installed_extensions_list( # noqa: C901
if ext_id in settings.lnbits_installed_extensions_ids:
continue
- ext_releases = await InstallableExtension.get_extension_releases(ext_id)
+ ext_releases = await InstallableExtension.get_extension_releases(
+ ext_id, include_payment_info=False
+ )
ext_releases = sorted(
ext_releases, key=lambda r: version_parse(r.version), reverse=True
)
### lnbits/core/migrations.py
@@ -1045,3 +1045,23 @@ async def m056_disable_public_registration(db: Connection):
async def m057_add_payment_extension_context(db: Connection):
# Keep trusted invoice routing separate from externally supplied extra data.
await db.execute("ALTER TABLE apipayments ADD COLUMN extension_context TEXT")
+
+
+async def m058_clear_extensions_reviews_url(db: Connection):
+ # Preserve first-start superuser setup when no admin settings exist yet.
+ await db.execute("""
+ INSERT INTO system_settings (id, value, tag)
+ SELECT 'lnbits_extensions_reviews_url', '""', 'core'
+ WHERE EXISTS (
+ SELECT 1 FROM system_settings WHERE id = 'super_user' AND tag = 'core'
+ )
+ ON CONFLICT (id, tag) DO UPDATE SET value = '""'
+ """)
+ await db.execute("""
+ UPDATE system_settings SET value = '""'
+ WHERE id = 'lnbits_extensions_reviews_url' AND tag = 'core'
+ """)
+ # Apply the one-time reset before first-start settings are persisted, too.
+ from lnbits.settings import settings
+
+ settings.lnbits_extensions_reviews_url = ""
### lnbits/core/models/extensions.py
@@ -791,7 +791,9 @@ async def find_latest_compatible_release(self) -> ExtensionRelease | None:
return None
latest = None
latest_version = Version(installed.version)
- for release in await self.get_extension_releases(self.id):
+ for release in await self.get_extension_releases(
+ self.id, include_payment_info=False
+ ):
if (
release.source_repo != installed.source_repo
or not release.is_version_compatible
@@ -1072,7 +1074,9 @@ async def _get_installable_extensions(
return extension_list
@classmethod
- async def get_extension_releases(cls, ext_id: str) -> list[ExtensionRelease]:
+ async def get_extension_releases(
+ cls, ext_id: str, *, include_payment_info: bool = True
+ ) -> list[ExtensionRelease]:
extension_releases: list[ExtensionRelease] = []
for url, manifest_type in _extension_manifest_sources(
include_builder=True, deduplicate=False
@@ -1102,7 +1106,8 @@ async def get_extension_releases(cls, ext_id: str) -> list[ExtensionRelease]:
)
explicit_release.apply_config(config)
explicit_release.manifest_type = manifest_type
- await explicit_release.check_payment_requirements()
+ if include_payment_info:
+ await explicit_release.check_payment_requirements()
extension_releases.append(explicit_release)
except Exception as e:
### lnbits/core/services/extensions.py
@@ -818,12 +818,14 @@ async def _auto_update_extension(
payment = ext.find_existing_payment(release.pay_link)
if payment:
release.payment_hash = payment.payment_hash
+ release.cost_sats = payment.amount
elif (
release.pay_link
and updated.meta.installed_release
and updated.meta.installed_release.pay_link == release.pay_link
):
release.payment_hash = updated.meta.installed_release.payment_hash
+ release.cost_sats = updated.meta.installed_release.cost_sats
updated.version = release.version
updated.meta.installed_release = release
### lnbits/settings.py
@@ -92,7 +92,7 @@ class ExtensionsSettings(LNbitsSettings):
lnbits_extensions_builder_activate_non_admins: bool = Field(default=False)
lnbits_wasm_invocation_retention_days: int = Field(default=7, ge=0)
lnbits_extensions_reviews_url: str = Field(
- default="https://demo.lnbits.com/paidreviews/api/v1/AdFzLjzuKFLsdk4Bcnff6r",
+ default="",
description="""
URL for the paid reviews.
Regular users can view this URL (not secret).
@@ -1243,7 +1243,7 @@ def check_auth_secret_key(self):
return
if not os.path.isdir(settings.lnbits_data_folder):
os.mkdir(settings.lnbits_data_folder)
- auth_key_file = Path(settings.lnbits_data_folder, ".lnbits_auth_key")
+ auth_key_file = Path(settings.lnbits_data_folder, ".lnbits_auth_key_v1")
if auth_key_file.is_file():
with open(auth_key_file) as file:
self.auth_secret_key = file.readline()
### pyproject.toml
@@ -1,6 +1,6 @@
[project]
name = "lnbits"
-version = "1.7.0-rc4"
+version = "1.7.1"
requires-python = ">=3.10,<3.14"
description = "LNbits, free and open-source Lightning wallet and accounts system."
authors = [{ name = "Alan Bits", email = "alan@lnbits.com" }]
@@ -169,6 +169,7 @@ module = [
"pyln.client.*",
"py_vapid.*",
"pywebpush.*",
+ "http_ece.*",
"fastapi_sso.sso.*",
"json5.*",
"jsonpath_ng.*",
### tests/api/test_extension_api.py
@@ -825,9 +825,10 @@ async def test_extension_api_activate_uninstall_install_invoice_and_cleanup(mock
@pytest.mark.anyio
-async def test_extension_api_review_endpoints(mocker):
+async def test_extension_api_review_endpoints(mocker, settings):
ext_id = f"review_{uuid4().hex[:8]}"
- reviews_base = "https://demo.lnbits.com/paidreviews/api/v1/AdFzLjzuKFLsdk4Bcnff6r"
+ reviews_base = "https://reviews.example.com/api/v1/test"
+ settings.lnbits_extensions_reviews_url = reviews_base
tags_url = f"{reviews_base}/tags"
reviews_url = f"{reviews_base}/reviews/{ext_id}?offset=0&limit=5"
create_review_url = f"{reviews_base}/reviews"
### tests/unit/onchain/test_migrations.py
@@ -27,6 +27,9 @@ async def test_onchain_schema_uses_wallets_and_addresses(
id TEXT, value TEXT, tag TEXT, UNIQUE(id, tag)
)
""")
+ await conn.execute("""
+ CREATE TABLE apipayments (checking_id TEXT PRIMARY KEY)
+ """)
await conn.execute("""
CREATE TABLE wallets (
id TEXT PRIMARY KEY,
### tests/unit/test_extension_autoupdate.py
@@ -128,10 +128,13 @@ async def test_autoupdate_latest_compatible_preserves_state_and_paid_access(
ctx = update_context
settings.lnbits_autoupdate_extensions_interval_hours = interval
ctx.ext.active = active
+ ctx.ext.meta.installed_release.cost_sats = 100
if active:
ctx.ext.meta.payments = [
ReleasePaymentInfo(
- pay_link=ctx.release.pay_link, payment_hash="existing-payment"
+ amount=200,
+ pay_link=ctx.release.pay_link,
+ payment_hash="existing-payment",
)
]
if not active:
@@ -164,6 +167,7 @@ async def migrate(ext, _version):
assert (ctx.ext.id in settings.lnbits_deactivated_extensions) is (not active)
assert "payment_hash=existing-payment" in ctx.download.call_args.args[0]
assert saved.meta.installed_release.payment_hash == "existing-payment"
+ assert saved.meta.installed_release.cost_sats == (200 if active else 100)
assert saved.meta.payments == ctx.ext.meta.payments
assert ctx.ext.installed_version == "1.0.0"
ctx.deactivate.assert_not_awaited()
### tests/unit/test_models_extensions.py
@@ -2,6 +2,7 @@
import pytest
from pytest_mock.plugin import MockerFixture
+from lnbits.app import build_all_installed_extensions_list
from lnbits.core.models.extensions import (
ExtensionConfig,
ExtensionManifestType,
@@ -12,6 +13,7 @@
github_api_get,
)
from lnbits.settings import Settings
+from tests.helpers import make_installable_extension
def _mock_json_response(mocker: MockerFixture, url: str, payload: dict):
@@ -41,6 +43,66 @@ def _extension_config_payload() -> dict:
}
+@pytest.mark.anyio
+@pytest.mark.parametrize("lookup", ["releases", "update", "default_install"])
+async def test_release_prices_are_only_fetched_for_interactive_requests(
+ settings: Settings, mocker: MockerFixture, tmp_path, monkeypatch, lookup
+):
+ settings.lnbits_extensions_manifests = []
+ settings.lnbits_wasm_extensions_manifests = []
+ ext = make_installable_extension("paidext")
+ assert ext.meta and ext.meta.installed_release
+ ext.meta.installed_release.source_repo = (
+ settings.lnbits_extensions_builder_manifest_url
+ )
+ pay_link = "https://example.com/pay"
+ manifest = Manifest.model_validate(
+ {
+ "extensions": [
+ {
+ "id": ext.id,
+ "name": ext.name,
+ "version": "2.0.0",
+ "archive": "https://example.com/paidext.zip",
+ "hash": "release-hash",
+ "pay_link": pay_link,
+ }
+ ]
+ }
+ )
+ mocker.patch.object(InstallableExtension, "fetch_manifest", return_value=manifest)
+ client_factory, client = _mock_json_response(mocker, pay_link, {"amount": 100})
+
+ release: ExtensionRelease | None
+ if lookup == "releases":
+ releases = await InstallableExtension.get_extension_releases(ext.id)
+ assert len(releases) == 1
+ release = releases[0]
+ elif lookup == "update":
+ release = await ext.find_latest_compatible_release()
+ else:
+ monkeypatch.setattr(settings, "lnbits_extensions_path", str(tmp_path / "code"))
+ monkeypatch.setattr(
+ settings, "lnbits_wasm_extensions_path", str(tmp_path / "wasm")
+ )
+ settings.lnbits_extensions_default_install = [ext.id]
+ mocker.patch("lnbits.app.get_installed_extensions", return_value=[])
+ extensions = await build_all_installed_extensions_list()
+ assert len(extensions) == 1
+ assert extensions[0].meta
+ release = extensions[0].meta.installed_release
+
+ assert release
+ assert release.version == "2.0.0"
+ assert release.pay_link == pay_link
+ if lookup == "releases":
+ assert release.cost_sats == 100
+ client.get.assert_awaited_once_with(pay_link)
+ else:
+ assert release.cost_sats is None
+ client_factory.assert_not_called()
+
+
@pytest.mark.anyio
async def test_get_installable_extensions_loads_wasm_manifests(
settings: Settings, mocker: MockerFixture
### tests/unit/test_settings.py
@@ -537,7 +537,7 @@ def test_set_cli_settings_updates_runtime_settings(settings: Settings):
@pytest.mark.parametrize(
"field,filename",
[
- ("auth_secret_key", ".lnbits_auth_key"),
+ ("auth_secret_key", ".lnbits_auth_key_v1"),
("totp_encryption_key", ".lnbits_totp_key"),
],
)
@@ -567,7 +567,7 @@ def test_secret_key_file_lifecycle(settings, tmp_path, monkeypatch, field, filen
@pytest.mark.parametrize(
"field,filename",
[
- ("auth_secret_key", ".lnbits_auth_key"),
+ ("auth_secret_key", ".lnbits_auth_key_v1"),
("totp_encryption_key", ".lnbits_totp_key"),
],
)
### tests/unit/test_settings_migrations.py
@@ -0,0 +1,95 @@
+import json
+
+import pytest
+
+from lnbits.core import migrations
+from lnbits.core.crud.db_versions import get_db_version, update_migration_version
+from lnbits.core.crud.settings import get_settings_field
+from lnbits.core.helpers import run_migration
+from lnbits.db import DB_TYPE, SQLITE, Database
+
+
+@pytest.mark.anyio
+@pytest.mark.parametrize("has_super_user", [False, True])
+@pytest.mark.parametrize(
+ "saved_url",
+ [
+ None,
+ "",
+ "https://demo.lnbits.com/paidreviews/api/v1/AdFzLjzuKFLsdk4Bcnff6r",
+ "https://reviews.example.com/api/v1/custom",
+ ],
+)
+async def test_reviews_url_migration_resets_once(
+ tmp_path, settings, has_super_user, saved_url
+):
+ if DB_TYPE != SQLITE:
+ pytest.skip("temporary settings database is SQLite-only")
+
+ settings.lnbits_data_folder = str(tmp_path)
+ settings.lnbits_extensions_reviews_url = "https://reviews.example.com/from-env"
+ db = Database("settings_migration")
+ try:
+ async with db.connect() as conn:
+ await migrations.m000_create_migrations_table(conn)
+ await conn.execute("""
+ CREATE TABLE system_settings (
+ id TEXT PRIMARY KEY,
+ value TEXT,
+ tag TEXT NOT NULL DEFAULT 'core',
+ UNIQUE(id, tag)
+ )
+ """)
+ if has_super_user:
+ await conn.execute("""
+ INSERT INTO system_settings (id, value, tag)
+ VALUES ('super_user', '"admin"', 'core'),
+ ('extension_setting', '"keep"', 'extension')
+ """)
+ if saved_url is not None:
+ await conn.execute(
+ """
+ INSERT INTO system_settings (id, value, tag)
+ VALUES ('lnbits_extensions_reviews_url', :value, 'core')
+ """,
+ {"value": json.dumps(saved_url)},
+ )
+ await update_migration_version(conn, "core", 57)
+ await run_migration(
+ conn, migrations, "core", await get_db_version("core", conn)
+ )
+
+ assert settings.lnbits_extensions_reviews_url == ""
+ field = await get_settings_field("lnbits_extensions_reviews_url", conn=conn)
+ if has_super_user or saved_url is not None:
+ assert field is not None
+ assert field.value == ""
+ else:
+ assert await conn.fetchall("SELECT * FROM system_settings") == []
+ if has_super_user:
+ admin = await get_settings_field("super_user", conn=conn)
+ assert admin is not None and admin.value == "admin"
+ extension = await get_settings_field(
+ "extension_setting", "extension", conn=conn
+ )
+ assert extension is not None and extension.value == "keep"
+
+ # A URL configured after the migration survives subsequent startups.
+ configured_url = "https://reviews.example.com/reconfigured"
+ await conn.execute(
+ """
+ INSERT INTO system_settings (id, value, tag)
+ VALUES ('lnbits_extensions_reviews_url', :value, 'core')
+ ON CONFLICT (id, tag) DO UPDATE SET value = :value
+ """,
+ {"value": json.dumps(configured_url)},
+ )
+ settings.lnbits_extensions_reviews_url = configured_url
+ version = await get_db_version("core", conn)
+ assert version is not None and version.version == 58
+ await run_migration(conn, migrations, "core", version)
+ field = await get_settings_field("lnbits_extensions_reviews_url", conn=conn)
+ assert field is not None and field.value == configured_url
+ assert settings.lnbits_extensions_reviews_url == configured_url
+ finally:
+ await db.engine.dispose()
### uv.lock
@@ -1668,7 +1668,7 @@ wheels = [
[[package]]
name = "lnbits"
-version = "1.7.0rc4"
+version = "1.7.1"
source = { editable = "." }
dependencies = [
{ name = "aiosqlite" },Why this scored 49/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.