AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Bitcoin

feat: improve on create wallet frontend and api. (BREAKING CHANGE) (#3635)

Public commit record

What the developer wrote

Authored by dni ⚡

70/100 · Adequate
feat: improve on create wallet frontend and api. (BREAKING CHANGE) (#3635)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit changes how wallets are created through the LNbits API. Previously, creating a wallet required an admin key from an existing wallet. After this change, it only requires proof that an account exists. This is a deliberate redesign, but it removes an authorization layer: anyone who can present a valid account identifier can now create a new wallet for that account, whereas before they also needed an existing wallet's admin key. The commit does not explain why this is safe or what replaces the old check, so it may weaken access controls.

Recommended action

Review the new `check_account_id_exists` dependency to confirm it also enforces that the caller is authenticated as the account owner or an authorized admin. Verify that the frontend only calls this endpoint in authenticated contexts and that the account identifier cannot be guessed or supplied by another user. Add regression tests covering cross-account wallet creation attempts.

Security signals we found

01

Authorization downgrade: endpoint no longer requires an admin key; it only validates account existence.

02

Breaking API change in a wallet-creation endpoint.

03

Account-scoped wallet creation now driven by `account_id` parameter rather than wallet key.

04

No visible replacement authorization check in the server-side diff.

05

Frontend bundles and Vue components were updated to match the new API contract.

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 6/15
Affected reach 8/15
Confidence 5/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.