AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 59 Bitcoin

feat: onchain wallet type (#4194)

Public commit record

What the developer wrote

Authored by Arc

65/100 · Adequate
feat: onchain wallet type (#4194)
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This is a large feature commit that adds native Bitcoin on-chain wallet support to LNbits, including hot wallets whose recovery phrases are encrypted by a server-side master key. It introduces new code paths for key management, address derivation, blockchain scanning, transaction signing, and broadcasting. Because the commit is a feature addition rather than a documented security fix, the main risk is that any bugs or design weaknesses in the new on-chain subsystem could lead to loss of funds, key exposure, or incorrect balances. The diff itself does not show an obvious exploitable vulnerability, but the size and sensitivity of the code mean the change should be reviewed carefully before being trusted with real funds.

Recommended action

Treat this as a high-risk feature commit, not a routine dependency update. Before deploying with real funds: review the new on-chain key lifecycle (generation, backup, restore, rotation), verify that the encrypted seed is never logged or returned in API responses, audit the signing path for memory handling of plaintext mnemonics, test the super-user authorization on admin on-chain endpoints, and run the included on-chain unit and e2e tests. Consider additional code audit or fuzzing of the PSBT/extract/broadcast endpoints because they process externally supplied transaction data.

Security signals we found

01

New server-side hot wallet signing that decrypts BIP39 mnemonics in process

02

New master encryption key stored on the server filesystem and optionally in environment variables

03

New on-chain API surface with admin/read key scoping and super-user gating for enabling payments

04

New database migrations adding on-chain wallet state and a balances view that sums UTXOs for on-chain wallets

05

Validation added for derivation paths, transaction amounts, output networks, and broadcast responses

06

Sensitive endpoints set Cache-Control: no-store / Pragma: no-cache

07

Atomic, owner-only key file creation with a check that prevents replacing an existing key

Risk score

Why this scored 59/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 12/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.