AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 75 Bitcoin

fix: forward ip (#4132)

Public commit record

What the developer wrote

Authored by Vlad Stan

48/100 · Thin
fix: forward ip (#4132)
✓ Subject identifies a change✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit is a large security-focused patch for LNbits. It replaces the external library's LNURL handling with custom code that validates URLs, blocks private/internal IP addresses by default, limits redirects, and prevents credential leaks. It also hardens webhooks, login throttling, database backup commands, callback URL checks, and fixes Stripe/PayPal currency handling. The default authentication method is changed to username+password only, removing the weaker 'user-id-only' default.

Recommended action

Review and merge promptly; this is a defensive security patch. After deployment, verify that legitimate LNURL services, webhooks, and fiat provider integrations still work, especially any using Tor/onion addresses or custom redirect rules. Update admin documentation for new settings: LNBITS_LNURL_REDIRECT_URL_RULES, LNBITS_LNURL_ALLOW_PRIVATE_IPS, LNBITS_CALLBACK_ALLOW_PRIVATE_IPS, and the changed default AUTH_ALLOWED_METHODS.

Security signals we found

01

SSRF protection added for LNURL and webhook outgoing requests

02

Private IP and localhost blocking by default for LNURL and callbacks

03

Custom LNURL client replaces library calls with redirect limits and response size limits

04

Command injection mitigation in pg_dump backup via shell=False

05

Login brute-force throttling with exponential backoff

06

Callback URL validation hardened (scheme, host, port, credentials, fullmatch regex)

07

Default authentication method changed to username-password only

08

Stripe/PayPal amount/currency handling fixes

Risk score

Why this scored 75/100

Our methodology →
Potential impact 22/30
Exploitability 18/25
Stealth signal 10/15
Affected reach 14/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.