AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 52 Bitcoin

fix: ignore failed payments in daily withdraw limit (#4297)

Public commit record

What the developer wrote

Authored by Amartya Vikram Singh

70/100 · Adequate
fix: ignore failed payments in daily withdraw limit (#4297)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a bug in LNbits where failed outgoing payments were incorrectly counted against a wallet's daily withdrawal limit. Because failed payments never actually moved money out of the wallet, counting them could wrongly block legitimate withdrawals. The fix adds a filter so only completed (successful) outgoing payments are tallied.

Recommended action

Review whether other payment-summation or limit-checking functions (e.g., fee totals, balance checks, admin limits) also need explicit `complete=True` or equivalent state filtering. Deploy the patch and verify the new unit tests pass.

Security signals we found

01

Business-logic flaw in access-control / spending limit

02

Incorrect state filter on financial transaction query

03

Denial-of-service-like effect: legitimate withdrawals blocked by stale failed payment records

04

Fix validated by new unit tests covering both success and failure states

Risk score

Why this scored 52/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.